Skip to content
This repository has been archived by the owner on Mar 15, 2021. It is now read-only.

Add support for s390x in Github Actions #21

Merged
merged 1 commit into from
May 20, 2020

Conversation

prabhav-thali
Copy link
Contributor

Signed-off-by: Prabhav Thali Prabhav.Thali1@ibm.com

What does this PR do?

Adds s390x support in docker buildx command for Github actions workflow.

What issues does this PR fix or reference?

This PR is part of this initiative.

Signed-off-by: Prabhav Thali <Prabhav.Thali1@ibm.com>
@akurinnoy
Copy link
Contributor

Hi @prabhav-thali, thanks for the pull request!

Please sign ECA, then we'll be able to merge it.

@prabhav-thali
Copy link
Contributor Author

@akurinnoy I have signed the ECA.

@akurinnoy akurinnoy merged commit 48e5781 into eclipse-che:master May 20, 2020
@prabhav-thali
Copy link
Contributor Author

@akurinnoy I observed that this PR was merged before 7.13.1 release. However, only the image with next tag is available on quay.io and there is no s390x image for 7.13.1 release. Could you please provide some info on this?

@skabashnyuk
Copy link
Contributor

@akurinnoy I observed that this PR was merged before 7.13.1 release. However, only the image with next tag is available on quay.io and there is no s390x image for 7.13.1 release. Could you please provide some info on this?

@prabhav-thali

@mkuznyetsov or @nickboldt is working on releases I think they better know the answer to your question.

@nickboldt
Copy link
Contributor

merged before 7.13.1 release

Yes but only in master branch. 7.13.z releases are done from the 7.13.x branch, not from master.

@prabhav-thali
Copy link
Contributor Author

Same happened with release 7.14.1 i.e. no image for s390x is published. @nickboldt @mkuznyetsov Could you please check?

@nickboldt
Copy link
Contributor

nickboldt commented Jun 9, 2020

Workspace loader images are not used for anything but internal Che assembly processes.

So for now we're not publishing them as multi-arch artifacts on Quay, probably because we're also not immediately planning to build Che images for Z and P.

Ultimately, to get there, we need to retool the build process to build on multiple arches, and publish those artifacts.

Since no one has yet looked at this issue, I've opened this task:

eclipse-che/che#17124

Will you be able to contribute PRs to make the Che release process skopeo-enabled and multiarch?

@prabhav-thali
Copy link
Contributor Author

@nickboldt Thanks for the update on release process.

Ultimately, to get there, we need to retool the build process to build on multiple arches, and publish those artifacts.

We have already started on this by adding buildx support in CICO scripts. Could you please take a look at the PR#109 we have raised for che-machine-exec?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants