feat: Adding 'ephemeral' parameter for the Getting Started samples #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
approved these changes
Dec 23, 2022
|
@nickboldt the samples are broken, could you please take a look
|
Signed-off-by: ibuziuk <ibuziuk@che>
ibuziuk
force-pushed
the
ephemeral_samples
branch
from
0b7da8a
to
b45d03a
Compare
|
They're not broken. They're set up so that we don't have to change them when we GA. To work around references to not-yet-released images, use an ImageContentSourcePolicy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ibuziuk ibuziuk@che