Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add a warning about blocked oauth popup #815

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Add a warning about blocked oauth popup #815

merged 1 commit into from
Jul 27, 2020

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jul 27, 2020

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

If the getUserToken() function works longer then 10 sec. warning notification about blocked oauth popup appears.

What issues does this PR fix or reference?

eclipse-che/che#16930

Release Notes

Docs PR

Hapy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jul 27, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:815
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:815

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@benoitf
Copy link
Contributor

benoitf commented Jul 27, 2020

Hello Igor,

if the user is taking more than 10s to complete oAuth it will also display this popup ?

@vinokurig
Copy link
Contributor Author

Hello Florent,
It is expected that user is already logged in to Che when this function is called, so the popup window which is a web-application from che-server should just open and close immediately after sending the user token back.

@vinokurig vinokurig merged commit 2f11124 into master Jul 27, 2020
@vinokurig vinokurig deleted the che-16930 branch July 27, 2020 13:24
@che-bot che-bot added this to the 7.17 milestone Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants