Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

CHE-11954: Add che.registerTaskRunner Theia Plugin API #8

Merged
merged 1 commit into from
Jan 16, 2019
Merged

CHE-11954: Add che.registerTaskRunner Theia Plugin API #8

merged 1 commit into from
Jan 16, 2019

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Dec 28, 2018 •
edited
Loading

@vinokurig vinokurig force-pushed the che-task branch 12 times, most recently from 3294ae6 to 76c27cb Compare December 29, 2018 08:21
@vinokurig vinokurig force-pushed the che-task branch 5 times, most recently from 0ea7e03 to 3b77fb5 Compare January 2, 2019 14:38
@vinokurig vinokurig requested a review from benoitf January 2, 2019 14:44
@vinokurig vinokurig force-pushed the che-task branch 2 times, most recently from 13e7f37 to a19e918 Compare January 3, 2019 07:28
@vitaliy-guliy
Copy link
Contributor

Travis failed with

src/node/che-task-service.ts(84,11): error TS2416: Property 'getRuntimeInfo' in type 'CheTask' is not assignable to the same property in base type 'Task'.
```

@vinokurig
Copy link
Contributor Author

vinokurig commented Jan 3, 2019 •
edited
Loading

@vitaliy-guliy that's because the PR depends on eclipse-theia/theia#3909, when theia 3.19 is released it will be fixed.

@evidolob
Copy link
Contributor

evidolob commented Jan 3, 2019

@vinokurig there is some errors during build:

src/node/che-task-service.ts(45,13): error TS2322: Type 'CheTask' is not assignable to type 'Task'.
  Types of property 'getRuntimeInfo' are incompatible.
    Type '() => Promise<TaskInfo>' is not assignable to type '() => TaskInfo'.
src/node/che-task-service.ts(84,11): error TS2416: Property 'getRuntimeInfo' in type 'CheTask' is not assignable to the same property in base type 'Task'.
  Type '() => Promise<TaskInfo>' is not assignable to type '() => TaskInfo'.
    Type 'Promise<TaskInfo>' is not assignable to type 'TaskInfo'.
      Property 'taskId' is missing in type 'Promise<TaskInfo>'.

@vinokurig
Copy link
Contributor Author

@evidolob It is expected, I've merged some related changes to Theia repo (eclipse-theia/theia#3909) and since it is not released, the PR build fails.

@vinokurig
Copy link
Contributor Author

Need to set 0.3.19 when Theia is released.

@vinokurig vinokurig force-pushed the che-task branch 2 times, most recently from a73d6b9 to 6c4f056 Compare January 10, 2019 15:02
@vinokurig vinokurig merged commit ba54416 into master Jan 16, 2019
@vinokurig vinokurig deleted the che-task branch January 16, 2019 12:33
@vinokurig vinokurig restored the che-task branch January 17, 2019 09:55
vinokurig added a commit that referenced this pull request Jan 17, 2019
@vinokurig
Revert "CHE-11954: Add che.registerTaskRunner Theia Plugin API (#8)"
5271501 
This reverts commit ba54416.
@vinokurig vinokurig mentioned this pull request Jan 17, 2019
Merged
vinokurig added a commit that referenced this pull request Jan 17, 2019
@vinokurig
Revert "CHE-11954: Add che.registerTaskRunner Theia Plugin API" (#27)
fe26d58 
* Revert "Change TaskConfiguration field to be competable with Theia core (#26)"

This reverts commit 1857d63.

* Revert "CHE-11954: Add che.registerTaskRunner Theia Plugin API (#8)"

This reverts commit ba54416.
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
@skabashnyuk
Add links to meta.yaml (#8)
171de88
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@azatsarynnyy azatsarynnyy azatsarynnyy left review comments

@RomanNikitenko RomanNikitenko RomanNikitenko left review comments

@evidolob evidolob evidolob approved these changes

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy

@benoitf benoitf Awaiting requested review from benoitf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Theia][Plugin] Add TaskRunner API
5 participants
@vinokurig @vitaliy-guliy @evidolob @azatsarynnyy @RomanNikitenko