Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Stabilize Cypress test: Check Invalid Syntax #795

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Stabilize Cypress test: Check Invalid Syntax #795

merged 2 commits into from
Jul 7, 2020

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Jul 6, 2020 •
edited
Loading

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Makes Check Invalid Syntax test stable.

What issues does this PR fix or reference?

closes eclipse-che/che#17095

Release Notes

Docs PR

@azatsarynnyy
Revert back disabled Cypress test
13d99dd 
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jul 6, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:795
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:795

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@azatsarynnyy
Add a delay to wait for explorer to be opened
d5ade46 
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
benoitf
benoitf approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for later ;-)

@che-bot
Copy link
Contributor

che-bot commented Jul 6, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:795
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:795

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@azatsarynnyy
Copy link
Member Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 6, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:795
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:795

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@azatsarynnyy
Copy link
Member Author

crw-ci-test

@azatsarynnyy
Copy link
Member Author

[ci-build]

1 similar comment
@azatsarynnyy
Copy link
Member Author

[ci-build]

@che-bot
Copy link
Contributor

che-bot commented Jul 6, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:795
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:795

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@azatsarynnyy
Copy link
Member Author

I did several passes by re-running the CI jobs.
Check Invalid Syntax test was green all times. So, it's stable now. 🎉

@azatsarynnyy azatsarynnyy marked this pull request as ready for review July 7, 2020 05:35
@azatsarynnyy azatsarynnyy merged commit b6e3173 into master Jul 7, 2020
@azatsarynnyy azatsarynnyy deleted the cypress-test branch July 7, 2020 05:36
@azatsarynnyy azatsarynnyy changed the title Revert back disabled Cypress test Stabilize Cypress test: Check Invalid Syntax Jul 13, 2020
@che-bot
Copy link
Contributor

che-bot commented Jul 13, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:795
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:795

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

vinokurig pushed a commit that referenced this pull request Apr 6, 2021
@JPinkney
Update vscode-yaml to 0.14.0 (#795)
bf3299d 
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benoitf benoitf benoitf approved these changes

@RomanNikitenko RomanNikitenko Awaiting requested review from RomanNikitenko

@vzhukovs vzhukovs Awaiting requested review from vzhukovs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Che Theia Cypress tests stable
3 participants
@azatsarynnyy @che-bot @benoitf