This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Adapt terminal widget to the upstream #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svor <vsvydenk@redhat.com>
svor
requested review from
azatsarynnyy,
benoitf,
RomanNikitenko and
vzhukovs
as code owners
|
@vzhukovskii this fix should resolve eclipse-che/che#16856 as well |
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
| @@ -37,6 +37,11 @@ export interface RemoteTerminalWidgetFactoryOptions extends Partial<TerminalWidg | |||
| created: string | |||
| } | |||
|
|
|||
| export interface TerminalProcessInfo { | |||
There was a problem hiding this comment.
Can't this interface be reused from upstream's base-terminal-protocol.ts?
Signed-off-by: svor <vsvydenk@redhat.com>
Sounds promising. Let me check 🤞 |
|
crw-ci-build |
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
vzhukovs
approved these changes
May 18, 2020
azatsarynnyy
approved these changes
May 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: svor vsvydenk@redhat.com
What does this PR do?
Adds
get processInfo(): Promise<TerminalProcessInfo>method to make it possible to run debug commands in internalTerminal.Upstream changes: eclipse-theia/theia@5e45d2b#diff-29ae8bb3747051f34ef7d32716b705e6
What issues does this PR fix or reference?
eclipse-che/che#16805