Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Update dependencies #7

Merged
merged 2 commits into from
Dec 21, 2018
Merged

Update dependencies #7

merged 2 commits into from
Dec 21, 2018

Conversation

vitaliy-guliy
Copy link
Contributor

Update dependency versions

@benoitf
Copy link
Contributor

benoitf commented Dec 21, 2018

yarn.lock is not updated ?

@vitaliy-guliy
Copy link
Contributor Author

@benoitf already updated

benoitf
benoitf approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me if travis is going to green mode :-)

@vitaliy-guliy vitaliy-guliy merged commit f670ee6 into master Dec 21, 2018
@vitaliy-guliy vitaliy-guliy deleted the update-ws-client-version branch December 21, 2018 12:57
@benoitf
Copy link
Contributor

benoitf commented Dec 21, 2018

@vitaliy-guliy why did you merge before travis finished ?
https://travis-ci.org/eclipse/che-theia/builds/470962851?utm_source=github_status&utm_medium=notification

@vitaliy-guliy
Copy link
Contributor Author

I thought travis builds the master after merging PR.

@benoitf
Copy link
Contributor

benoitf commented Dec 21, 2018

@vitaliy-guliy AFAIK there is a build of the PR and after merge, a build of master

vinokurig pushed a commit that referenced this pull request Apr 6, 2021
@mkuznyetsov
Update URLs to match new release (#7)
8605206
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benoitf benoitf benoitf approved these changes

@evidolob evidolob evidolob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitaliy-guliy @benoitf @evidolob