This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Autodetect a MIME-type of the logo for branding #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
azatsarynnyy
requested review from
benoitf,
RomanNikitenko and
vzhukovs
as code owners
benoitf
approved these changes
Mar 18, 2020
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
* hlasm-language-support 0.11.1 New version of plugin hlasm-language-support 0.11.1 Signed-off-by: Filip Kroupa <filip.kroupa@broadcom.com> * Remove hlasm-language-support 0.11.0 Remove older plugin version, as only one should be in the registry. See eclipse-che/che#18183 Signed-off-by: Filip Kroupa <filip.kroupa@broadcom.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com
What does this PR do?
Adds a mime-type autodetection of a product logo image when it's returned by che-product-service. A mime-type is set within base64 data url.
What issues does this PR fix or reference?
closes eclipse-che/che#16392
Release Notes
Docs PR