This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
CHE Factory plugin API #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
reviewed
Dec 18, 2018
| @@ -28,7 +28,7 @@ declare module '@eclipse-che/plugin' { | |||
| } | |||
|
|
|||
| export namespace factory { | |||
| export function getFactoryById(id: string): PromiseLike<Factory | undefined>; | |||
| export function getById(id: string): PromiseLike<MYFactory>; | |||
There was a problem hiding this comment.
hello, it looks strange to have MyFactory ?
There was a problem hiding this comment.
hello, but it is MYFactory but not MyFactory ;)
There was a problem hiding this comment.
ok @sleshchenko it changes everything 🤣
evidolob
approved these changes
Dec 19, 2018
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
Add type of the object to the index file of che-plugin-registry (#6)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHE Factory plugin API Implementation.