Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Use a dedicated server as webview domain #591

Merged
merged 5 commits into from
Feb 5, 2020
Merged

Use a dedicated server as webview domain #591

merged 5 commits into from
Feb 5, 2020

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Dec 29, 2019

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Uses a dedicated endpoint to deploy all webviews separately from Che Theia editor endpoint.
It increases security since all webviews don't have access to the data of Che Theia window.

Note, this PR depends on a couple of other PRs (already merged):

To test it:

metadata:
  name: webviews
apiVersion: 1.0.0
components:
  - reference: https://raw.githubusercontent.com/azatsarynnyy/che-plugin-registry/master/v3/plugins/eclipse/che-theia/next/meta.yaml
    type: cheEditor
  • see that theia sidecar has webviews endpoint which is used for loading webview of Welcome page

What issues does this PR fix or reference?

closes eclipse-che/che#15616

Release Notes

Docs PR

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@che-bot

This comment was marked as outdated.

@che-bot

This comment was marked as outdated.

@azatsarynnyy azatsarynnyy marked this pull request as ready for review February 2, 2020 18:00
@che-bot

This comment was marked as outdated.

Copy link
Contributor

@vzhukovs vzhukovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other looks good to me

@vzhukovs vzhukovs added kind/enhancement New feature or request severity/P1 labels Feb 4, 2020
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@che-bot

This comment was marked as outdated.

@che-bot
Copy link
Contributor

che-bot commented Feb 4, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:591
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:591

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@azatsarynnyy azatsarynnyy merged commit 6309583 into master Feb 5, 2020
@azatsarynnyy azatsarynnyy deleted the az-webview branch February 5, 2020 05:34
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
* add vuejs extension
* fix release date
* bump node to 12
* Remove .git from repo

Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>
Co-authored-by: Eric Williams <ericwill@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request severity/P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Theia WebViews more secure
5 participants