Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add ability to configure borders in quick pick items list on plugin side #532

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Nov 4, 2019

What does this PR do?

This changes proposal align behavior to select target container when new terminal opens or new task starts. By the design the flow from the Find command action was taken. To separate developer and tooling containers:

When Find command is executed:
Снимок экрана 2019-11-04 в 14 34 15

When new terminal opens:
Снимок экрана 2019-11-04 в 14 34 23

When new task starts:
Снимок экрана 2019-11-04 в 14 34 41

Devfile to test changes: https://gist.github.com/vzhukovskii/23b275d18af208629648430df251a78e/raw/6451e1d0589cb435bf58208d560fb8006e338cd8/che-dev-workspace.yaml

Steps to test changes manually:

  • clone [che-theia](https://github.com/eclipse/che-theia) and theia
  • checkout to quick_pick_items_ext in che-theia and theia repo
  • build che-theia, then go to dockerfile/theia and build docker image: ./build.sh --build-args:GITHUB_TOKEN=${GITHUB_TOKEN},THEIA_VERSION=master --tag:next --branch:quick_pick_items_ext --git-ref:refs\\/heads\\/quick_pick_items_ext --skip-tests
  • use built docker image eclipse/che-theia:next as image for the main editor in che.

Signed-off-by: Vlad Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

eclipse-che/che#13390

Release Notes

Add ability to configure borders in quick pick items list on plugin side

Docs PR

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Nov 6, 2019

@vzhukovskii
I get list of containers with group label if I have both: Developer and Tooling containers

terminal_with

but I get list of containers without group label if I have only Tooling containers for example.

terminal_without

Is it expected behavior?

@vzhukovs
Copy link
Contributor Author

vzhukovs commented Nov 6, 2019

@RomanNikitenko yes, it's expected behavior

@eclipse-che eclipse-che deleted a comment from che-bot Nov 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Nov 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Nov 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Nov 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Nov 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Nov 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Nov 11, 2019
}

export function isDevContainer(container: WorkspaceContainer): boolean {
return container.attributes !== undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!container.attributes is better because cover null check, but up to you.

@AndrienkoAleksandr
Copy link
Contributor

Looks like happy tests should be reworked by qa, because UI changed.

Copy link
Member

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, the list of containers with group label is displayed:

  • at creating a new terminal
  • at running a task if component is not defined in a configuration

The comment contains case when group label is not displayed for containers

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@eclipse-che eclipse-che deleted a comment from che-bot Nov 12, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Nov 12, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Nov 12, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Nov 12, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Nov 12, 2019
@che-bot
Copy link
Contributor

che-bot commented Nov 12, 2019

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:532
che-remote-plugin-node docker.io/maxura/che-remote-plugin-node:532
che-remote-plugin-runner-java8 docker.io/maxura/che-remote-plugin-runner-java8:532
che-remote-plugin-kubernetes-tooling-1.0.0 docker.io/maxura/che-remote-plugin-kubernetes-tooling-1.0.0:532

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@musienko-maxim
Copy link

On this moment we have problem with PR check jobs, all steps from happy path was checked manually. The steps passed.

@vzhukovs vzhukovs merged commit 81ef8e7 into master Nov 12, 2019
@vzhukovs vzhukovs deleted the quick_pick_items_ext branch November 12, 2019 15:52
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request team/ide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants