This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Validate SSH keys list before view/delete #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinokurig
requested review from
l0rd,
olexii4,
rhopp,
sunix,
vitaliy-guliy and
vparfonov
as code owners
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
benoitf
reviewed
Oct 2, 2019
| const getKeys = async (sshKeyManager: SshKeyManager): Promise<cheApi.ssh.SshPair[]> => { | ||
| const keys: cheApi.ssh.SshPair[] = await sshKeyManager.getAll('vcs'); | ||
| if (!keys || keys.length < 1) { | ||
| throw new Error('No SSH key pairs has been defined.'); |
There was a problem hiding this comment.
SSH Key Pair
or
SSH Key Pairs have
| try { | ||
| keys = await getKeys(sshkeyManager); | ||
| } catch (error) { | ||
| theia.window.showWarningMessage(error.message); |
There was a problem hiding this comment.
should say that we're trying to delete in warning message
Comment on lines
167
to
175
| let keys: cheApi.ssh.SshPair[]; | ||
| try { | ||
| keys = await getKeys(sshkeyManager); | ||
| } catch (error) { | ||
| theia.window.showWarningMessage(error.message); | ||
| return; | ||
| } |
There was a problem hiding this comment.
we could move to a separate method as we're using twice
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
25 tasks
benoitf
approved these changes
Oct 2, 2019
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
* Buildah base dev plugin * Buildah dev plugin 1.14.0 * Update reference to docker image * Change memory limitation to 1gb Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What does this PR do?
Validate SSH key list in the view / delete actions of the SSH Plugin
What issues does this PR fix or reference?
eclipse-che/che#14218
Release Notes
Docs PR