Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Generate settings.xml if MAVEN_MIRROR_URL is set #429

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 6, 2019

Signed-off-by: Anatoliy Bazko abazko@redhat.com

What does this PR do?

Generates /home/theia/.m2/settings.xml if MAVEN_MIRROR_URL is set.

<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
                      https://maven.apache.org/xsd/settings-1.0.0.xsd">
  <mirrors>
    <mirror>
      <url>${env.MAVEN_MIRROR_URL}</url>
      <mirrorOf>external:*</mirrorOf>
    </mirror>
  </mirrors>
</settings>

What issues does this PR fix or reference?

eclipse-che/che#14391

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha added the kind/enhancement New feature or request label Sep 6, 2019
@tolusha tolusha requested review from benoitf and l0rd September 6, 2019 09:54
@tolusha tolusha self-assigned this Sep 6, 2019
@tolusha tolusha changed the title Generate settings.xml Generate settings.xml if MAVEN_MIRROR_URL is set Sep 6, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 6, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@tolusha
Copy link
Contributor Author

tolusha commented Sep 9, 2019

@benoitf
Could you validate the PR ?

@benoitf
Copy link
Contributor

benoitf commented Sep 9, 2019

@tolusha why do we have M2 settings in theia endpoint ? it's not related to any programming language

@benoitf
Copy link
Contributor

benoitf commented Sep 9, 2019

Probably you're requiring like /entrypoint.sh including optional like /before-start.sh and include that file in the java endpoint containers ?

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Sep 10, 2019

@benoitf
I've updated the PR

@che-bot
Copy link
Contributor

che-bot commented Sep 10, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 10, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@tolusha tolusha merged commit fc11a43 into master Sep 10, 2019
@tolusha tolusha deleted the ab/maven_mirrow branch September 10, 2019 14:25
dmytro-ndp pushed a commit that referenced this pull request Sep 11, 2019
* Generate settings.xml

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants