This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
[SSH] Add no key pair warnings #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorkem
requested review from
evidolob,
l0rd,
olexii4,
rhopp,
sunix,
vitaliy-guliy and
vparfonov
as code owners
vinokurig
reviewed
Aug 19, 2019
| @@ -82,8 +82,16 @@ const writeKey = async (name: string, key: string) => { | |||
| await chmod(keyFile, '600'); | |||
| }; | |||
|
|
|||
| const showWarning = async () => { | |||
| theia.window.showWarningMessage('Che Git plugin can leverage the generated keys now. To make them available in every workspace containers please restart your workspace.'); | |||
| const warning = async (message: string) => { | |||
There was a problem hiding this comment.
It is a function. I think showWarning suites more
vinokurig
reviewed
Aug 19, 2019
vinokurig
reviewed
Aug 19, 2019
Adds warnings to view and delete keys when no key pairs exist.
gorkem
force-pushed
the
ssh-no-key-warn
branch
from
1e8a13a
to
70a2b66
Compare
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
closing as outdated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds warnings to view and delete keys when no key pairs exist.
fixes eclipse-che/che#14215