Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

chore(recommendations-plugin): Use upper tsconfig file #1215

Merged
merged 2 commits into from
Sep 7, 2021
Merged

chore(recommendations-plugin): Use upper tsconfig file #1215

merged 2 commits into from
Sep 7, 2021

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Sep 7, 2021

What does this PR do?

recommendations plug-in was using a custom (one that is added by the yeoman generator) while it should use upper configuration like the other plug-ins

Screenshot/screencast of this PR

What issues does this PR fix or reference?

N/A

How to test this PR?

Recommendations plug-in should work as before

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

@codecov
Copy link

codecov bot commented Sep 7, 2021 •
edited
Loading

Codecov Report

Merging #1215 (d98f24b) into main (c299f59) will decrease coverage by 0.09%.
The diff coverage is 19.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
- Coverage   32.78%   32.69%   -0.10%     
==========================================
  Files         290      295       +5     
  Lines        9885    10005     +120     
  Branches     1457     1550      +93     
==========================================
+ Hits         3241     3271      +30     
+ Misses       6641     6625      -16     
- Partials        3      109     +106
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...he-server/src/node/che-server-http-service-impl.ts 0.00% <0.00%> (ø)
...-che-server/src/node/che-server-remote-api-impl.ts 38.88% <0.00%> (ø)
...browser/contribution/exec-terminal-contribution.ts 0.00% <0.00%> (ø)
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fafc3f...d98f24b. Read the comment docs.

@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1215
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1215

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

tsmaeder
tsmaeder suggested changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the "es5", lgtm.

plugins/recommendations-plugin/tsconfig.json Outdated
],
}
,
"target": "es5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other plugins are using "es6" or nothing at all (inherited from the base config) for a target.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I copy it from containers-plugin:
There are many other references https://github.com/eclipse-che/che-theia/search?q=es5
And it'll be replaced anyway by #1213 so it's like uneeded requirement

@benoitf
chore(tsconfig): Use upper configuration instead of a custom one
a783abe 
Change-Id: I0fd532e6e2012d61d7ce03bf089ccc47dd827814
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
chore(cleanup): Remove unused code
d98f24b 
Change-Id: I8e7a2a8d5a8feb04b9f91457d297e6a0d5ee0f29
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
tsmaeder
tsmaeder approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1215
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1215

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@benoitf benoitf merged commit cf562f1 into eclipse-che:main Sep 7, 2021
@benoitf benoitf deleted the fix-tsconfig branch September 7, 2021 14:45
@che-bot che-bot added this to the 7.36 milestone Sep 7, 2021
@RomanNikitenko RomanNikitenko mentioned this pull request Sep 10, 2021
Merged
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsmaeder tsmaeder tsmaeder approved these changes

@sunix sunix Awaiting requested review from sunix

@svor svor Awaiting requested review from svor svor is a code owner

@vinokurig vinokurig Awaiting requested review from vinokurig vinokurig is a code owner

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy vitaliy-guliy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.36
Development

Successfully merging this pull request may close these issues.
3 participants
@benoitf @che-bot @tsmaeder