Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add CA certificates from all bundles from /public-certs directory #1038

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Mar 18, 2021

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Imports all CA certificates bundles from /public-certs directory in Che-Theia IDE container.
It is commonly that the bundle might have pem file extension. Other extensions are possible too, but used not so often. To not to add an additional constraint to the certificates bundle for Che, just import it regardless the bundle file extension.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#17938

How to test this PR?

  1. Add a tusted bundle into Che using pem file extension
  2. Start a workspace
  3. Check that Che-Theia imported the certificates from the bundle.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1038
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1038

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what I've discovered this morning while investigating eclipse-che/che#19309 (comment)
Cool! Thanks!

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #1038 (7e86f33) into master (d4a190e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1038   +/-   ##
=======================================
  Coverage   21.11%   21.12%           
=======================================
  Files         302      302           
  Lines       11152    11150    -2     
  Branches     1682     1680    -2     
=======================================
  Hits         2355     2355           
+ Misses       8652     8650    -2     
  Partials      145      145           
Impacted Files Coverage Δ
...er/src/node/che-server-certificate-service-impl.ts 0.00% <0.00%> (ø)
plugins/workspace-plugin/src/ca-cert.ts 41.66% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a190e...7e86f33. Read the comment docs.

@azatsarynnyy azatsarynnyy merged commit d059cdf into master Mar 18, 2021
@azatsarynnyy azatsarynnyy deleted the che-17938 branch March 18, 2021 17:39
@che-bot che-bot added this to the 7.28 milestone Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants