Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add a doc on how to include an upstream Theia patch into the Che-Theia release #1032

Merged
merged 5 commits into from
Mar 17, 2021

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Mar 16, 2021

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Adds a doc on how to include an upstream Theia patch into the Che-Theia release.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

closes eclipse-che/che#19141, https://issues.redhat.com/browse/RHDEVDOCS-2741

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1032
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1032

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #1032 (3fcff4a) into master (2628ea7) will decrease coverage by 0.70%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
- Coverage   21.07%   20.36%   -0.71%     
==========================================
  Files         298      302       +4     
  Lines       11090    11486     +396     
  Branches     1680     1744      +64     
==========================================
+ Hits         2337     2339       +2     
- Misses       8603     8994     +391     
- Partials      150      153       +3     
Impacted Files Coverage Δ
...theia-plugin-remote/src/node/plugin-remote-init.ts 0.00% <0.00%> (ø)
...ia-plugin-remote/src/node/plugin-remote-mapping.ts 0.00% <0.00%> (ø)
...-plugin-remote/src/node/plugin-reader-extension.ts 0.00% <0.00%> (ø)
...in-remote/src/node/plugin-remote-backend-module.ts 0.00% <0.00%> (ø)
...emote/src/browser/plugin-remote-frontend-module.ts 0.00% <0.00%> (ø)
...a-plugin-remote/src/node/che-plugin-uri-factory.ts 0.00% <0.00%> (ø)
...e-theia-plugin-remote/src/common/che-plugin-uri.ts 0.00% <0.00%> (ø)
...-theia-plugin-remote/src/node/internal-protocol.ts 0.00% <0.00%> (ø)
...lugin-remote/src/browser/che-plugin-file-system.ts 0.00% <0.00%> (ø)
...eia-plugin-remote/src/node/hosted-plugin-remote.ts 0.55% <0.00%> (+0.55%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2628ea7...3fcff4a. Read the comment docs.

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice doc.

I think you should run the content against che-docs vale plug-in to remove all past tense form

The Theia or Che-Theia fork is not clear to me (there is codeready workspaces example)

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@dmytro-ndp
Copy link
Contributor

[crw-ci-test --rebuild]

@che-bot
Copy link
Contributor

che-bot commented Mar 17, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1032
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1032

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@azatsarynnyy
Copy link
Member Author

I think you should run the content against che-docs vale plug-in to remove all past tense form

@benoitf the only way I know how to check it with the che-docs vale plug-in - it's open a draft PR and look at the check's output.
Do you know a simpler or quicker way?

azatsarynnyy and others added 3 commits March 17, 2021 15:51
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 17, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1032
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1032

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@azatsarynnyy azatsarynnyy merged commit d4a190e into master Mar 17, 2021
@azatsarynnyy azatsarynnyy deleted the rel-doc branch March 17, 2021 21:48
@che-bot che-bot added this to the 7.28 milestone Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to include an upstream Theia patch into Che-Theia release
4 participants