-
Notifications
You must be signed in to change notification settings - Fork 111
Add a doc on how to include an upstream Theia patch into the Che-Theia release #1032
Conversation
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
Codecov Report
@@ Coverage Diff @@
## master #1032 +/- ##
==========================================
- Coverage 21.07% 20.36% -0.71%
==========================================
Files 298 302 +4
Lines 11090 11486 +396
Branches 1680 1744 +64
==========================================
+ Hits 2337 2339 +2
- Misses 8603 8994 +391
- Partials 150 153 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice doc.
I think you should run the content against che-docs vale plug-in to remove all past tense form
The Theia or Che-Theia fork is not clear to me (there is codeready workspaces example)
[crw-ci-test --rebuild] |
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
@benoitf the only way I know how to check it with the che-docs vale plug-in - it's open a draft PR and look at the check's output. |
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com
What does this PR do?
Adds a doc on how to include an upstream Theia patch into the Che-Theia release.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
closes eclipse-che/che#19141, https://issues.redhat.com/browse/RHDEVDOCS-2741
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable