-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python-jupyter): Setting up venv in a dedicated volume #958
Conversation
5fdab27
to
90dd3ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benoitf, sunix The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
ae06ad5
to
90dd3ad
Compare
Signed-off-by: Sun Seng David TAN <sutan@redhat.com>
90dd3ad
to
ade1202
Compare
@benoitf ... for some reasons when i tried to merge, the gh actions are broken ... it works well locally with podman but it is hard for me to fix it as i cannot reproduce. OK to merge like that ? |
@sunix: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Sun Seng David TAN sutan@redhat.com
What does this PR do?
Sidecar part, using the same venv folder for:
requirements.txt
Screenshot/screencast of this PR
https://youtu.be/FPZa5jc8sYE
What issues does this PR fix or reference?
eclipse-che/che#16818
How to test this PR?
will come with the plugin part (in a second PR once this is merged) but could be tested with:
and the flow:
AzureTextAnalyticsRestAPI.ipynb
requests
set up venv with requirements
pandas
requirements.txt
set up venv with requirements
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.