Temporarily remove some plugins where vsix files are missing #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of eclipse-che/che#18933 Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill
requested review from
benoitf,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
sunix
reviewed
Feb 1, 2021
| extensions: | ||
| - https://open-vsx.org/api/haskell/haskell/1.1.0/file/haskell.haskell-1.1.0.vsix | ||
| - https://open-vsx.org/api/justusadam/language-haskell/3.3.0/file/justusadam.language-haskell-3.3.0.vsix | ||
| - https://open-vsx.org/api/gattytto/phoityne-vscode/0.0.28/file/gattytto.phoityne-vscode-0.0.28.vsix |
There was a problem hiding this comment.
I am wondering if we could just disable phoityne-vscode. Not sure what is the impact.
There was a problem hiding this comment.
I didn't contribute this plugin so I don't know. Better remove it and we can add it back later.
|
Should be part of the next che hotfix z release eclipse-che/che#18926 7.25.2 |
benoitf
reviewed
Feb 1, 2021
| url: https://github.com/rogalmic/vscode-bash-debug | ||
| revision: v0.3.9 | ||
| extensions: | ||
| - https://open-vsx.org/api/rogalmic/bash-debug/0.3.9/file/rogalmic.bash-debug-0.3.9.vsix |
There was a problem hiding this comment.
benoitf
approved these changes
Feb 1, 2021
Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill
added a commit
that referenced
this pull request
Feb 2, 2021
…829) * Temporarily remove some plugins where vsix files are missing Part of eclipse-che/che#18933 Signed-off-by: Eric Williams <ericwill@redhat.com> * Update bash-debug location instead of removing Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Williams ericwill@redhat.com
What does this PR do?
Temporarily remove plugins that have dead vsix links, until we can replace the links and enable offline builds by default.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Part of eclipse-che/che#18933
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.