Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ruby): Fix ruby plugin setting default settings to be used #813

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

sunix
Copy link
Contributor

@sunix sunix commented Jan 24, 2021

Signed-off-by: Sun Seng David TAN sutan@redhat.com

What does this PR do?

Fixing settings needed for ruby plugin to work.
Using hack as mentioned in eclipse-che/che#17975 (comment)

Settings needed: eclipse-che/che#18871 (comment)

Screenshot/screencast of this PR

Selection_177

What issues does this PR fix or reference?

Fix eclipse-che/che#18871

How to test this PR?

  1. Start this devfile:
apiVersion: 1.0.0
metadata:
  generateName: ruby-test-fix-settings-
projects:
  - name: rails-mister-cocktail
    source:
      type: github
      location: https://github.com/omontigny/rails-mister-cocktail
components:
  - id: castwide/solargraph/latest
    type: chePlugin
    registryUrl: 'https://sunix-che-plugin-registry-fix-ruby-yjb3d.surge.sh/v3'
  1. edit any .rb file
  2. see code completion is working

the provided registry refers to this manually built image which contains the changes: https://quay.io/repository/sunix/che-plugin-sidecar/manifest/sha256:bf376396c578cbd30877172abf3cc02dfeea58afa1403d44f4c2d2c7aeefd3d3

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>
@sunix sunix changed the title fix(sidecar): Fix ruby plugin setting default settings to be used fix(ruby): Fix ruby plugin setting default settings to be used Jan 25, 2021
@ericwill ericwill merged commit 68a9a70 into master Jan 25, 2021
@ericwill ericwill deleted the fix-ruby-settings branch January 25, 2021 15:04
@che-bot che-bot added this to the 7.26 milestone Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ruby plugin fails to start: can't find solargraph
3 participants