Update CONTRIBUTE.md #751
Merged
Update CONTRIBUTE.md #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove final `vscode-extensions.json` reference.
ericwill
requested review from
benoitf,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
@benoitf do we still need two PRs for updating a sidecar + plugin? I think it can be done together now, no? |
JPinkney
approved these changes
Dec 8, 2020
|
I think we still need two PRs because I'm not sure there are dependencies between workflow jobs Also from testing point of view I suppose we should publish images of side-cars from PR so anyone can test it without rebuilding it |
benoitf
approved these changes
Dec 8, 2020
|
@ericwill ready to merge ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes final
vscode-extensions.jsonreference.Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#18215
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.