Add a GitHub action based release job #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwill
requested review from
benoitf,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
benoitf
approved these changes
Dec 1, 2020
nickboldt
reviewed
Dec 4, 2020
nickboldt
reviewed
Dec 4, 2020
nickboldt
reviewed
Dec 4, 2020
nickboldt
reviewed
Dec 7, 2020
nickboldt
approved these changes
Dec 7, 2020
Part of eclipse-che/che#18072 Signed-off-by: Eric Williams <ericwill@redhat.com>
Signed-off-by: Eric Williams <ericwill@redhat.com>
Signed-off-by: Eric Williams <ericwill@redhat.com>
|
@benoitf do you have the secrets to log into Dockerhub? |
|
yes I think I can get some |
|
I can register them tomorrow if it works for you |
Any time before next Wednesday's release works fine, thanks! Also please for the devfile registry, as there is the same PR there. |
This was referenced Dec 11, 2020
|
I forgot to say but I added the docker.io credentials this morning (my morning :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Williams ericwill@redhat.com
What does this PR do?
Calls
make-release.shwith the necessary parameters to release the che-plugin-registry without using centos-ci. Added build/publish steps to themake-release.shscript.Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Part of eclipse-che/che#18072
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.