Explicitly include plugins' dependencies in their meta.yaml #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
requested review from
ibuziuk,
l0rd,
rhopp,
skabashnyuk and
vparfonov
as code owners
sleshchenko
approved these changes
Jan 24, 2020
|
Note also that in terms of functionality, nothing is changed in this PR; with the dependency resolution mechanism in Theia, the extensions I've added to this PR are downloaded automatically at workspace start. This simply makes the process explicit in the plugin meta.yaml and downloads them via the plugin broker instead. |
nickboldt
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
+2 because @sleshchenko approved but I'm a code owner for some reason. :) muahaha the power.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates plugin metas to include all extensions and extensions dependencies.
Issue
Fixes eclipse-che/che#15795
Fixes eclipse-che/che#15730
Details
Plugin dependencies were computed by
package.jsonforextensionDependenciesusing the script here, which produces the output shown below.
Plugin dependences