Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: plugin reg updates to move away from download.jboss.org (CRW-2662) & update to newer versions #1222

Closed
wants to merge 2 commits into from

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Mar 8, 2022

What does this PR do?

Fix / chore: followup to #19952

Removals:

  • remove obsolete node-debug and node-debug2
  • wsdl2rest removed (per @apupier this is no longer needed)

Updates / URL changes:

  • vscode-js-debug 1.52.2 -> 1.66.0 (also fix GH project URL)
  • clangd 0.1.5 -> 0.1.15
  • cdt-gdb-vscode 0.0.91 -> 0.0.92
  • php intelephense-client 1.5.4 -> 1.8.2
  • camelk 0.0.26 -> 0.0.30
  • microprofile-0.1.1 -> 0.3.0
  • quarkus 1.7 -> 1.9
  • fabric8-analytics 0.2.1 (was mislabelled as 0.1.0) -> 0.3.5
  • project-initializer 0.0.10 -> 0.2.1
  • openshift-connector 0.2.9 -> 0.2.13
  • php-debug 1.13 -> 1.22.0
  • eslint-2.1.1 -> 2.1.20

URL change only:

  • cdt-vscode-0.0.7-75cf95 (unchanged, just moved host)
  • python (unchanged, just moved host)
  • quarkus 1.5 -> 1.5 (unchanged, just moved host; needed for JDK 8)
  • java-debug-0.26.0 (moved host only)
  • redhat.java-0.82.0 (moved host only)
  • redhat.java-0.63.0 (moved host only; for JDK 8)
  • mta 0.0.63 (moved host only) @johnsteele FYI if you want something newer, submit a PR
  • kubernetes-tools-1.2.1 (moved host only)
  • sonarlint-1.20.1 (moved host only)

Questions:

  • apache-camel 0.1.5 -> 0.2.0 **** NOT SURE about trustedHashes annotation? @apupier
  • xml 0.1.7 **** NOT SURE about skipDependencies annotation? @benoitf

This PR also includes the changes in #1221

Change-Id: I5dec0733ab2fc316027cfae42ecd513b17546493
Signed-off-by: nickboldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#19952
https://issues.redhat.com/browse/CRW-2662

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Change-Id: I5dec0733ab2fc316027cfae42ecd513b17546493
Signed-off-by: nickboldt <nboldt@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Click here to review and test in web IDE: Contribute

@nickboldt nickboldt requested a review from ericwill March 8, 2022 19:55
@benoitf
Copy link
Contributor

benoitf commented Mar 8, 2022

Have you tested those versions ?

… remove some obsolete stuff

Change-Id: I45959417eb5dcc82d52c19f4dee392e8f8ffdad6
Signed-off-by: nickboldt <nboldt@redhat.com>
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Click here to review and test in web IDE: Contribute

@nickboldt nickboldt changed the title chore: update to openshift-connector-0.2.13... chore: plugin reg updates to move away from download.jboss.org (CRW-2662) & update to newer versions Mar 8, 2022
@nickboldt
Copy link
Contributor Author

Have you tested those versions ?

hahaha, no. that's what the Happy Path is for, right? :D

@benoitf
Copy link
Contributor

benoitf commented Mar 9, 2022

@nickboldt happy path tests are not checking all the extensions (and it's not working for now)

I would just change the download link without changing/upgrading to newer versions

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't change version range. It might not work at all when upgrading to newer versions

@nickboldt
Copy link
Contributor Author

please don't change version range

Not always possible, unless we simply copy files from dl.jb.o -> gh release. I figured this was a good opportunity to update to newer or latest deps.

@benoitf
Copy link
Contributor

benoitf commented Mar 9, 2022

yes but I'm afraid the good opportunity might result in something broken due to API/compliance issue

@nickboldt
Copy link
Contributor Author

fair enough... I'll adapt my 'push to GH' script [1] so we can park a dozen files into the same gh release instead of producing a dozen individual releases w/ one asset per release [2].

[1] https://github.com/redhat-developer/codeready-workspaces-vscode-extensions/blob/main/build/copyFileToGHRelease.sh

[2] https://github.com/redhat-developer/codeready-workspaces-vscode-extensions/releases/tag/0.0.7-75cf95-cdt-vscode-assets

@apupier
Copy link
Contributor

apupier commented Mar 9, 2022

  • apache-camel 0.1.5 -> 0.2.0 **** NOT SURE about trustedHashes annotation? @apupier

no idea what is the trustedHashes but the only place where I see it in the PR is for VS Code XML, not Camel.
https://github.com/eclipse-che/che-plugin-registry/pull/1222/files#diff-325b78f5d70f8f6957b5b639b2ded282cf0ed56590cb6458a4020462b63c1d8aR469

so redirecting to @angelozerr

@angelozerr
Copy link

no idea what is the trustedHashes but the only place where I see it in the PR is for VS Code XML, not Camel.
https://github.com/eclipse-che/che-plugin-registry/pull/1222/files#diff->325b78f5d70f8f6957b5b639b2ded282cf0ed56590cb6458a4020462b63c1d8aR469

so redirecting to @angelozerr

@fbricon @rgrunber have you some ideas?

@fbricon
Copy link

fbricon commented Mar 9, 2022

trusted hashes concern the lemminx binaries downloaded by vscode-xml. Once downloaded, we check their hash is valid

@nickboldt
Copy link
Contributor Author

replaced by #1224 -- simpler solution (just move files)

@nickboldt nickboldt closed this Mar 10, 2022
@nickboldt
Copy link
Contributor Author

@fbricon @angelozerr @apupier

If you publish new .vsix files for use with Che or CRW, you'll need to put them somewhere other than download.jboss.org in future. If you're already pushing to open-vsx, cool, I can use those in future.

If you're not, then we'll need to find a new publishing mechanism (eg., to GH release). Hit me up (slack, GH/JIRA issue) if this applies to you.

@apupier
Copy link
Contributor

apupier commented Mar 10, 2022

All extensions with redhat as a publisher are pushed to Open VSX already, that's a requirement from Marketing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants