-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: plugin reg updates to move away from download.jboss.org (CRW-2662) & update to newer versions #1222
Conversation
Change-Id: I5dec0733ab2fc316027cfae42ecd513b17546493 Signed-off-by: nickboldt <nboldt@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nickboldt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Have you tested those versions ? |
… remove some obsolete stuff Change-Id: I45959417eb5dcc82d52c19f4dee392e8f8ffdad6 Signed-off-by: nickboldt <nboldt@redhat.com>
hahaha, no. that's what the Happy Path is for, right? :D |
@nickboldt happy path tests are not checking all the extensions (and it's not working for now) I would just change the download link without changing/upgrading to newer versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't change version range. It might not work at all when upgrading to newer versions
Not always possible, unless we simply copy files from dl.jb.o -> gh release. I figured this was a good opportunity to update to newer or latest deps. |
yes but I'm afraid the good opportunity might result in something broken due to API/compliance issue |
fair enough... I'll adapt my 'push to GH' script [1] so we can park a dozen files into the same gh release instead of producing a dozen individual releases w/ one asset per release [2]. |
no idea what is the so redirecting to @angelozerr |
|
trusted hashes concern the lemminx binaries downloaded by vscode-xml. Once downloaded, we check their hash is valid |
replaced by #1224 -- simpler solution (just move files) |
If you publish new .vsix files for use with Che or CRW, you'll need to put them somewhere other than download.jboss.org in future. If you're already pushing to open-vsx, cool, I can use those in future. If you're not, then we'll need to find a new publishing mechanism (eg., to GH release). Hit me up (slack, GH/JIRA issue) if this applies to you. |
All extensions with redhat as a publisher are pushed to Open VSX already, that's a requirement from Marketing. |
What does this PR do?
Fix / chore: followup to #19952
Removals:
Updates / URL changes:
URL change only:
Questions:
trustedHashes
annotation? @apupierskipDependencies
annotation? @benoitfThis PR also includes the changes in #1221
Change-Id: I5dec0733ab2fc316027cfae42ecd513b17546493
Signed-off-by: nickboldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#19952
https://issues.redhat.com/browse/CRW-2662
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.