Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add jsdebug VS Code Extension v1.52.2 #1039

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Sep 6, 2021

Signed-off-by: Thomas Mäder tmader@redhat.com

What does this PR do?

Add a plugin for js-debug, the default debugger in VS Code.

What issues does this PR fix or reference?

eclipse-che/che#19952

How to test this PR?

Create a workspace referencing the meta.yml generated by this PR

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Release Notes text

Add jsdebug VS Code Extension v1.52.2

Signed-off-by: Thomas Mäder <tmader@redhat.com>
@benoitf benoitf changed the title Add jsdebug pluing feat: Add jsdebug VS Code Extension v1.52.2 Sep 6, 2021
@benoitf
Copy link
Contributor

benoitf commented Sep 6, 2021

Was able to load the plug-in

while trying on workspaces.openshift.com the auto-attach is only showing the processes running in Theia IDE container (so even if we deploy extensions in the user-container it'll probably not show the user processes but it's not related to this PR)

Could be interesting to have shareProcessNamespace: true settings on the pod

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on workspaces.openshift.com

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, tsmaeder

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Sep 7, 2021

/retest

1 similar comment
@svor
Copy link
Contributor

svor commented Sep 7, 2021

/retest

@tsmaeder tsmaeder merged commit a953f4d into eclipse-che:main Sep 8, 2021
@che-bot che-bot added this to the 7.36 milestone Sep 8, 2021
@benoitf benoitf added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed labels Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants