This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
Make '-race' option configurable for s390x #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahidhs-ibm
requested review from
amisevsk,
l0rd,
nickboldt,
rhopp and
sleshchenko
as code owners
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 13 13
Lines 645 645
=======================================
Hits 479 479
Misses 158 158
Partials 8 8 Continue to review full report at Codecov.
|
Signed-off-by: Shahid Shaikh <shahid@us.ibm.com>
shahidhs-ibm
force-pushed
the
s390x_support
branch
from
6380aa8 to
b486753
Compare
benoitf
reviewed
Apr 27, 2020
|
seems the first article I read was incorrect. |
|
@benoitf Any update on merge? |
|
@nickboldt @benoitf When this PR can be merged? |
|
Not sure why this sat for 2 weeks without merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
'-race' flag is not supported on s390x architecture. This PR will remove '-race' option from
go testcommand (which gets executed inmake test).What issues does this PR fix or reference?
This PR is part of this initiative.