Make happy path tests to use latest templates from PR #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
flacatus
requested review from
AndrienkoAleksandr,
mmorhun,
nickboldt and
tolusha
as code owners
|
/test ? |
|
/test all |
Codecov Report
@@ Coverage Diff @@
## main #791 +/- ##
=======================================
Coverage 44.62% 44.62%
=======================================
Files 52 52
Lines 5185 5185
=======================================
Hits 2314 2314
Misses 2554 2554
Partials 317 317 Continue to review full report at Codecov.
|
|
/ok-to-test |
tolusha
approved these changes
Apr 21, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flacatus, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
63 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Flavius Lacatusu flacatus@redhat.com
What does this PR do?
Happy Path tests should use current templates to avoid inconsistency in testing.
For instance [1] Happy Path tests failed because new dashboard image wasn't used in deployment.
[1] #684
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.