Refactor exposure to have an ability share host among components #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun,
nickboldt and
tolusha
as code owners
11 tasks
sleshchenko
force-pushed
the
shareComponentsHost
branch
from
e0d593e
to
8b9213c
Compare
|
/retest |
tolusha
approved these changes
Apr 8, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sleshchenko, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
sleshchenko
force-pushed
the
shareComponentsHost
branch
from
831987b
to
e9a99c2
Compare
|
New changes are detected. LGTM label has been removed. |
|
rebased against master |
tolusha
force-pushed
the
shareComponentsHost
branch
from
e9a99c2
to
e0b44e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor exposure to have an ability to share host among components.
It's needed since even in multi-host dashboard used to share Che API host and we're not going to change it for time being.
Its usage can be found at another PR where a dedicated pod for Che Dashboard is implemented: 736efef#diff-a434bd1b85e2ebded7afe3539d59f554f735b7890ad997c99d170ef0f813a4a9R56
Screenshot/screencast of this PR
What issues does this PR fix or reference?
It's prereq for dashboard in a separate deployment #684
How to test this PR?
Nothing should be changed in user-facing stuff.
I tested:
OpenShift (RHPDS):
📓 I tested with dashboard changes but haven't retested after dropping it.
But nothing should change I believe.
Minikube:
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.