Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note clarifying that the kubernetes image puller operator is comm… #627

Conversation

tomgeorge
Copy link
Contributor

@tomgeorge tomgeorge commented Jan 13, 2021

…unity-supported

Signed-off-by: Tom George tgeorge@redhat.com

What does this PR do?

As part of the discussions around how to best add the kubernetes image puller into the che-operator[1], this PR adds a note that the image puller is considered community supported.

[1] See:

eclipse-che/che#18569
eclipse-che/che#18133
#541

Screenshot/screencast of this PR

imagepuller

What issues does this PR fix or reference?

eclipse-che/che#18569
eclipse-che/che#18133
#541

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tomgeorge
Copy link
Contributor Author

/retest

1 similar comment
@tolusha
Copy link
Contributor

tolusha commented Jan 14, 2021

/retest

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since I wrote the suggested new 'please note' addendum and 'community supported' descriptor, implied +1. :D

@sympatheticmoose
Copy link

Just to check, this will be disabled by default as shown in the screenshot? The user will have to choose to enable it - correct?

@tomgeorge
Copy link
Contributor Author

@sympatheticmoose that's correct

@tolusha
Copy link
Contributor

tolusha commented Jan 15, 2021

I've updated nightly bundle. For some reasons check passed but files weren't up to date.

@tolusha
Copy link
Contributor

tolusha commented Jan 15, 2021

Also I've removed empty line in a comment.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidfestal, ibuziuk, nickboldt, tolusha, tomgeorge
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

…unity-supported

Signed-off-by: Tom George <tgeorge@redhat.com>
@tomgeorge tomgeorge force-pushed the update-kubernetesimagepuller-community-support branch from 2940c61 to 48427f3 Compare January 18, 2021 15:32
@tomgeorge
Copy link
Contributor Author

/retest

@tomgeorge
Copy link
Contributor Author

/retest

1 similar comment
@tomgeorge
Copy link
Contributor Author

/retest

@tomgeorge tomgeorge merged commit 09b06d3 into eclipse-che:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants