Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nonProxyHosts documentation #1915

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Oct 8, 2024

What does this PR do?

Updates documentation in the CheCluster CR for nonProxyHosts

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7266

How to test this PR?

  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh
  1. Check documentation and verify that the new documentation appears:
$ oc explain checlusters.org.eclipse.che.spec.components.cheServer.proxy.nonProxyHosts

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@dkwon17 dkwon17 marked this pull request as draft October 9, 2024 03:52
@dkwon17 dkwon17 force-pushed the update-proxy-hosts-doc branch 2 times, most recently from 8654572 to f1023d5 Compare October 14, 2024 03:57
dkwon17 added a commit to dkwon17/che-operator that referenced this pull request Oct 18, 2024
Signed-off-by: dkwon17 <dakwon@redhat.com>
@dkwon17 dkwon17 force-pushed the update-proxy-hosts-doc branch from f1023d5 to ee131f0 Compare October 18, 2024 15:18
@dkwon17 dkwon17 marked this pull request as ready for review October 18, 2024 15:18
Copy link

openshift-ci bot commented Oct 18, 2024

@dkwon17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy ee131f0 link true /test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: dkwon17 <dakwon@redhat.com>
@dkwon17 dkwon17 force-pushed the update-proxy-hosts-doc branch from ee131f0 to 93780ac Compare October 23, 2024 05:24
Copy link

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkwon17, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17 dkwon17 merged commit 1daa6b0 into eclipse-che:main Oct 23, 2024
18 checks passed
@devstudio-release
Copy link

Build 3.18 :: operator_3.x/420: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: operator_3.x/420: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7895 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7950: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 65389562 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7953: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 65401135 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7954: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 65405929 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7955: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 65407747 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7960: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 65411399 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7962: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 65415129 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

dkwon17 added a commit to dkwon17/che-operator that referenced this pull request Nov 6, 2024
Signed-off-by: dkwon17 <dakwon@redhat.com>
dkwon17 added a commit that referenced this pull request Nov 14, 2024
Signed-off-by: dkwon17 <dakwon@redhat.com>
dkwon17 added a commit to dkwon17/che-operator that referenced this pull request Nov 29, 2024
Signed-off-by: dkwon17 <dakwon@redhat.com>
dkwon17 added a commit to dkwon17/che-operator that referenced this pull request Nov 29, 2024
Signed-off-by: dkwon17 <dakwon@redhat.com>
tolusha pushed a commit that referenced this pull request Dec 2, 2024
Signed-off-by: dkwon17 <dakwon@redhat.com>
tolusha pushed a commit that referenced this pull request Dec 2, 2024
Signed-off-by: dkwon17 <dakwon@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants