CRW-4824 Updating annotations for operators to meet new OpenShift requirements

[SDawley]

What does this PR do?

There are newly implemented requirements (tests became mandatory last week) that requires a change in operator annotations:

https://docs.openshift.com/container-platform/4.15/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-annotations-infra_osdk-generating-csvs (see table 3)

So I’ve replaced

operators.openshift.io/infrastructure-features: '["disconnected", "proxy-aware",
  	"fips"]'

with

features.operators.openshift.io/disconnected: “true”
features.operators.openshift.io/fips-compliant: “true”
features.operators.openshift.io/proxy-aware: “true”
features.operators.openshift.io/tls-profiles: “true”
features.operators.openshift.io/token-auth-aws: “false” 
features.operators.openshift.io/token-auth-azure: “false” 
features.operators.openshift.io/token-auth-gcp: “false” 

Optional:

features.operators.openshift.io/cnf: “false” 
features.operators.openshift.io/cni: “false” 
features.operators.openshift.io/csi: “false” 

Justifications for true/false:

• Disconnected, fips and proxy-aware were already set using the old format
• tls-profiles I set to true because TLS mode is on by default and configurable.
• aws is false because I found AWS in vendor files but nothing that’s configurable on our end.
• azure is false because the OpenShift docs specifically mentioned the Cloud Credential Operator which I found no mention of/reference to.
• gcp is false for the same reason as Azure.
• cnf is false because I found no references to the Cloud-Native Network Function.
• cni is false because I only found references to the Container Network Interface in vendor files but nothing configured/configurable by Che.
• csi is false because like CNI the only references to the Container Storage Interface were in vendor files.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4824
Nick created this issue last year.

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Development resource are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SDawley

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tolusha]

I have some doubts about features.operators.openshift.io/tls-profiles: "true"
I would say it is false accordingly to https://docs.openshift.com/container-platform/4.15/operators/operator_sdk/osdk-generating-csvs.html

tls mode is always true and it isn't configurable.
Or I might misunderstand what configurable is.

[openshift-ci]

@SDawley: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v14-che-behind-proxy	3affd69	link	true	/test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[devstudio-release]

Build 3.13 :: operator-bundle_3.x/2676: Console, Changes, Git Data

[devstudio-release]

Build 3.13 :: sync-to-downstream_3.x/6262: Console, Changes, Git Data

[devstudio-release]

Build 3.13 :: get-sources-rhpkg-container-build_3.x/6206: Console, Changes, Git Data

[devstudio-release]

Build 3.13 :: push-latest-container-to-quay_3.x/4387: Console, Changes, Git Data

[devstudio-release]

Build 3.13 :: copyIIBsToQuay/2541: Console, Changes, Git Data

[devstudio-release]

Build 3.13 :: get-sources-rhpkg-container-build_3.x/6206:

devspaces-operator-bundle : 3.x :: Build 59650749 : quay.io/devspaces/devspaces-operator-bundle:3.13-36
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4387 triggered;

Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.13-16
- quay.io/devspaces/configbump-rhel8:3.13-2
- quay.io/devspaces/dashboard-rhel8:3.13-8
- quay.io/devspaces/devfileregistry-rhel8:3.13-23
- quay.io/devspaces/devspaces-rhel8-operator:3.13-4
- quay.io/devspaces/idea-rhel8:3.13-2
- quay.io/devspaces/pluginregistry-rhel8:3.13-7
- quay.io/devspaces/server-rhel8:3.13-5
- quay.io/devspaces/traefik-rhel8:3.13-2
- quay.io/devspaces/udi-rhel8:3.13-4
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202402081808.p0.gb17014f.assembly.stream.el8
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202401290832.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

[devstudio-release]

Build 3.13 :: sync-to-downstream_3.x/6262:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/6206 triggered; /job/DS_CI/job/dsc_3.x triggered;

[devstudio-release]

Build 3.13 :: operator-bundle_3.x/2676:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6262 triggered

[devstudio-release]

Build 3.13 :: dsc_3.x/1828: Console, Changes, Git Data

[devstudio-release]

Build 3.13 :: dsc_3.x/1828:

3.13.0-CI