feat: set default components container image and default editor

[tolusha]

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

set default components container image and default editor

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#21554

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Custom resource definition file is up to date
• OLM bundles are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[olexii4]

@tolusha Thank you very much for helping with eclipse-che/che#21554
I have tested it. It works as expected.
@ibuziuk @l0rd
What do you think about new defaults?

    defaultComponents:
      - container:
          image: 'quay.io/devfile/universal-developer-image:ubi8-latest'
        name: universal-developer-image
    defaultEditor: che-incubator/che-code/insiders

[ibuziuk]

Looks good to me in general, but I think @l0rd suggested using the tag instead of latest

• not sure if we need to additionally communicate the switch to che-code by default with the community

[l0rd]

Looks good to me in general, but I think @l0rd suggested using the tag instead of latest

* not sure if we need to additionally communicate the switch to che-code by default with the community

Yes please use theia as the default editor. We want the switch to happen when we are ready Dev Spaces side too (at least eclipse-che/che#20500 should be completed): we want to avoid having 2 different defaults upstream and downstream for a long time. And yes we need to communicate about that.

[l0rd]

And about using a specific tag: I think it's ok for nightly to use insiders or next but when we do a release we should use a specific tag/version. cc @nickboldt @mkuznyetsov.

[mkuznyetsov]

And about using a specific tag: I think it's ok for nightly to use insiders or next but when we do a release we should use a specific tag/version. cc @nickboldt @mkuznyetsov.

unlike other che-incubator/eclipse che projects, che-code doesn't have defined release workflow right now. I observe two workflows in it, one called insiders, that builds from pushes main branch, and one called stable, that builds from pushes to 1.y.z format branches (which was not used since 8 months ago).

[ibuziuk]

thanks, @tolusha LGTM 👍

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, olexii4, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v11-che-behind-proxy	508b8de	link	true	/test v11-che-behind-proxy
ci/prow/v11-devworkspace-happy-path	508b8de	link	true	/test v11-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[azatsarynnyy]

And about using a specific tag: I think it's ok for nightly to use insiders or next but when we do a release we should use a specific tag/version. cc @nickboldt @mkuznyetsov.

unlike other che-incubator/eclipse che projects, che-code doesn't have defined release workflow right now. I observe two workflows in it, one called insiders, that builds from pushes main branch, and one called stable, that builds from pushes to 1.y.z format branches (which was not used since 8 months ago).

You're right @mkuznyetsov, we have only next/insider images published.
There's a task to setup a release job for Che-Code: eclipse-che/che#21552