feat: Increase default memory limit for plug-in registry #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
nickboldt,
tolusha,
AndrienkoAleksandr and
flacatus
as code owners
When OpenVSX will be included in the plug-in registry It'll require more memory to start. With 256Mi, container is killed with OOM error Change-Id: I2ae148f858550f92d64c41d6fa81af826624b377 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
tolusha
approved these changes
Jul 27, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benoitf, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #1459 +/- ##
=======================================
Coverage 60.43% 60.43%
=======================================
Files 74 74
Lines 6288 6288
=======================================
Hits 3800 3800
Misses 2118 2118
Partials 370 370 Help us with your feedback. Take ten seconds to tell us how you rate us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When OpenVSX will be included in the plug-in registry
It'll require more memory to start.
With 256Mi, container is killed with OOM error
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20549
How to test this PR?
Deploy che and check more memory is assigned for plug-in registry container
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Change-Id: I2ae148f858550f92d64c41d6fa81af826624b377
Signed-off-by: Florent Benoit fbenoit@redhat.com