Fix OpenShift OAuth Proxy config

[olexii4]

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Fix OpenShift OAuth Proxy config.

We already have several openshift/oauth-proxy issues with redirection:

• The page isn’t redirecting properly with open PR
• skip-provider-button seems to force final redirection url to be / with open PR

These issues depend on setting skip-provider-button=true. It could always redirect to oauth/start.

I suggest using skip-provider-button=false as a quick fix until oauth-proxy PRs are waiting to be merged.

What issues does this PR fix or reference?

fixes eclipse-che/che#21352

How to test this PR?

It could be tested with platform OpenShift and this che-operator image: docker.io/olexii4dockerid/che-operator:next.

1. Deploy Che.

Example:

chectl server:deploy \
    --installer=operator \
    --platform=openshift \
    --che-operator-image=docker.io/olexii4dockerid/che-operator:next

2. Try to accept factory with URL without being logged in, like
   $CHE_HOST#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2.
3. Check that Dashboard is opened with factory flow
   $CHE_HOST/dashboard/#/load-factory?url=https://github.com/che-samples/java-spring-petclinic/tree/devfilev2. And the load-factory page has loaded without any errors.
4. Open the second tab with the dashboard.
5. Logout on the second tab and refresh the first one. You will see OAuth pages on bought tabs.
6. Try to login on bought tabs. login should be successful on bought tabs.

https://youtu.be/T7AqfANoA9c

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Custom resource definition file is up to date
• OLM bundles are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[tolusha]

/test v9-devworkspace-happy-path

[tolusha]

/test v9-devworkspace-happy-path

[openshift-ci]

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v9-devworkspace-happy-path	9e024e2	link	true	/test v9-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, olexii4, sparkoo, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment