Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactoring OpenShift Initial user reconciler #1152

Merged
merged 10 commits into from
Nov 4, 2021
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Oct 20, 2021

@tolusha
Copy link
Contributor Author

tolusha commented Oct 21, 2021

@mmorhun @AndrienkoAleksandr
Remarks addressed.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Nov 3, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2021

New changes are detected. LGTM label has been removed.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Copy link
Contributor

/retest

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1152 (ccd7d26) into main (cb17fce) will decrease coverage by 0.02%.
The diff coverage is 52.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
- Coverage   57.39%   57.37%   -0.03%     
==========================================
  Files          74       75       +1     
  Lines        8645     8631      -14     
==========================================
- Hits         4962     4952      -10     
+ Misses       3143     3140       -3     
+ Partials      540      539       -1     
Impacted Files Coverage Δ
controllers/che/checluster_validator.go 0.00% <0.00%> (ø)
pkg/deploy/identity-provider/identity_provider.go 10.23% <0.00%> (ø)
pkg/deploy/reconcile_manager.go 61.53% <0.00%> (ø)
pkg/util/util.go 14.54% <0.00%> (+0.25%) ⬆️
pkg/deploy/openshift-oauth/openshiftoauth_user.go 44.96% <44.96%> (ø)
pkg/deploy/openshift-oauth/openshiftoauth_util.go 60.00% <60.00%> (ø)
pkg/deploy/image-puller/imagepuller.go 62.12% <70.00%> (ø)
controllers/che/checluster_controller.go 26.73% <86.66%> (+2.03%) ⬆️
pkg/deploy/server/server_configmap.go 84.89% <100.00%> (ø)
pkg/deploy/test_util.go 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb17fce...ccd7d26. Read the comment docs.

@tolusha tolusha merged commit e1b4541 into main Nov 4, 2021
@tolusha tolusha deleted the refactoring branch November 4, 2021 15:42
@che-bot che-bot added this to the 7.39 milestone Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants