-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prepare community operators scripts to add new bundles format #1041
Conversation
We can merge after 7.35.2 |
d35ae07
to
ea49527
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello, @flacatus, @tolusha. I see in the community update script we are using migration from new bundle to old format bundle command:
|
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
b6a680d
to
5a8c858
Compare
Maybe we can move the function: source ${OPERATOR_REPO}/.github/bin/common.sh
getLatestsStableVersions to olm/prepare-community-operators-update.sh |
@flacatus: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
||
if [[ $channel == "stable-all-namespaces" ]];then | ||
# Add suffix for stable-<all-namespaces> channel | ||
LAST_PACKAGE_VERSION="$LAST_PACKAGE_VERSION-all-namespaces" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LAST_PACKAGE_VERSION="$LAST_PACKAGE_VERSION-all-namespaces" | |
LAST_PACKAGE_VERSION="${LAST_PACKAGE_VERSION}-all-namespaces" |
I think variable https://github.com/eclipse-che/che-operator/pull/1041/files#diff-87596dbd1244260e3d5bf59cc959c0aa3739edc345d88892fc7c6d8f3eaef2c8R115 is not used any more, so you can remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, flacatus, mmorhun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Flavius Lacatusu flacatus@redhat.com
What does this PR do?
This PR prepare the community operators to have new bundles format
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19244
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.