Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prepare community operators scripts to add new bundles format #1041

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

flacatus
Copy link
Contributor

@flacatus flacatus commented Aug 31, 2021

@flacatus
Copy link
Contributor Author

We can merge after 7.35.2

@flacatus flacatus force-pushed the migrate_comm branch 2 times, most recently from d35ae07 to ea49527 Compare August 31, 2021 09:27
Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Aug 31, 2021
@mmorhun mmorhun assigned flacatus and unassigned mmorhun Aug 31, 2021
@openshift-ci openshift-ci bot removed the lgtm label Aug 31, 2021
@flacatus flacatus changed the title feat: Prepare community operators to add new bundles format feat: Prepare community operators scripts to add new bundles format Aug 31, 2021
@AndrienkoAleksandr
Copy link
Contributor

Hello, @flacatus, @tolusha. I see in the community update script we are using migration from new bundle to old format bundle command:

${OPM_BINARY} index export --index="${INDEX_IMAGE}" --package="${packageName}" -c="docker" --download-folder "${manifestPackagesDir}"
Then we recopy files from old format to follow new bundle format file locations. Maybe in the frame of the issue: we should remove it eclipse-che/che#19244 and copy bundle from https://github.com/eclipse-che/che-operator/tree/86d748bee0de01756fd503bf418b677f4f6283be/bundle folder ? Or Did I misunderstand something?

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Contributor Author

Maybe we can move the function:

source ${OPERATOR_REPO}/.github/bin/common.sh
getLatestsStableVersions

to olm/prepare-community-operators-update.sh

@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2021

@flacatus: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/v7-devworkspace-happy-path 5a8c858 link /test v7-devworkspace-happy-path
ci/prow/v7-multi-host-next-deployment 5a8c858 link /test v7-multi-host-next-deployment

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha mentioned this pull request Sep 1, 2021
19 tasks

if [[ $channel == "stable-all-namespaces" ]];then
# Add suffix for stable-<all-namespaces> channel
LAST_PACKAGE_VERSION="$LAST_PACKAGE_VERSION-all-namespaces"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LAST_PACKAGE_VERSION="$LAST_PACKAGE_VERSION-all-namespaces"
LAST_PACKAGE_VERSION="${LAST_PACKAGE_VERSION}-all-namespaces"

@AndrienkoAleksandr
Copy link
Contributor

Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, flacatus, mmorhun

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha mentioned this pull request Sep 3, 2021
29 tasks
@flacatus flacatus merged commit 4c40166 into main Sep 3, 2021
@flacatus flacatus deleted the migrate_comm branch September 3, 2021 10:53
@che-bot che-bot added this to the 7.36 milestone Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants