feat: Support HorizontalPodAutoscaler

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

pkg/deploy/deployment.go

@@ -67,6 +67,10 @@ func SyncDeploymentSpecToCluster(
 		return false, err
 	}
 
+	if err := setDesiredReplicas(deploymentSpec, deployContext); err != nil {
+		return false, err
+	}
+
 	done, err := Sync(deployContext, deploymentSpec, deploymentDiffOpts)
 	if err != nil || !done {
 		// Failed to sync (update), let's delete and create instead
@@ -92,11 +96,11 @@ func SyncDeploymentSpecToCluster(
 		return false, err
 	}
 
-	if actual.Spec.Strategy.Type == appsv1.RollingUpdateDeploymentStrategyType && actual.Status.Replicas > 1 {
+	provisioned := actual.Status.UnavailableReplicas == 0
+	if actual.Spec.Strategy.Type == appsv1.RollingUpdateDeploymentStrategyType && !provisioned {
 		logrus.Infof("Deployment %s is in the rolling update state.", deploymentSpec.Name)
 	}
 
-	provisioned := actual.Status.AvailableReplicas == 1 && actual.Status.Replicas == 1
 	return provisioned, nil
 }
 
@@ -509,3 +513,14 @@ func MountConfigMaps(specDeployment *appsv1.Deployment, deployContext *chetypes.
 
 	return nil
 }
+
+// setDesiredReplicas sets replicas count from the actual deployment.
+func setDesiredReplicas(deployment *appsv1.Deployment, deployCtx *chetypes.DeployContext) error {
+	actual := &appsv1.Deployment{}
+	if exists, err := GetNamespacedObject(deployCtx, deployment.ObjectMeta.Name, actual); !exists {
+		return err
+	}
+
+	deployment.Spec.Replicas = actual.Spec.Replicas
+	return nil
+}

pkg/deploy/gateway/gateway.go

@@ -147,7 +147,7 @@ func syncAll(deployContext *chetypes.DeployContext) error {
 	if err != nil {
 		return err
 	}
-	if _, err := deploy.Sync(deployContext, depl, deploy.DefaultDeploymentDiffOpts); err != nil {
+	if _, err := deploy.SyncDeploymentSpecToCluster(deployContext, depl, deploy.DefaultDeploymentDiffOpts); err != nil {
 		// Failed to sync (update), let's delete and create instead
 		if strings.Contains(err.Error(), "field is immutable") {
 			if _, err := deploy.DeleteNamespacedObject(deployContext, depl.Name, &appsv1.Deployment{}); err != nil {

pkg/deploy/job.go

@@ -95,7 +95,6 @@ func getJobSpec(
 				},
 				Spec: corev1.PodSpec{
 					ServiceAccountName:            serviceAccountName,
-					DeprecatedServiceAccount:      serviceAccountName,
 					RestartPolicy:                 "Never",
 					TerminationGracePeriodSeconds: &terminationGracePeriodSeconds,
 					Containers: []corev1.Container{

pkg/deploy/registry/registry_deployment.go

@@ -19,7 +19,6 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/intstr"
-	"k8s.io/utils/pointer"
 )
 
 func GetSpecRegistryDeployment(
@@ -53,9 +52,7 @@ func GetSpecRegistryDeployment(
 			Labels:    labels,
 		},
 		Spec: appsv1.DeploymentSpec{
-			Replicas:             pointer.Int32Ptr(1),
-			RevisionHistoryLimit: pointer.Int32Ptr(2),
-			Selector:             &metav1.LabelSelector{MatchLabels: labelSelector},
+			Selector: &metav1.LabelSelector{MatchLabels: labelSelector},
 			Strategy: appsv1.DeploymentStrategy{
 				Type: appsv1.RollingUpdateDeploymentStrategyType,
 				RollingUpdate: &appsv1.RollingUpdateDeployment{

pkg/deploy/server/server_deployment.go

@@ -118,8 +118,7 @@ func (s CheServerReconciler) getDeploymentSpec(ctx *chetypes.DeployContext) (*ap
 					Labels: labels,
 				},
 				Spec: corev1.PodSpec{
-					ServiceAccountName:       "che",
-					DeprecatedServiceAccount: "che",
+					ServiceAccountName: "che",
 					Volumes: []corev1.Volume{
 						customPublicCertsVolume,
 					},

pkg/deploy/server/server_reconciler.go

@@ -102,13 +102,13 @@ func (s *CheServerReconciler) syncActiveChePhase(ctx *chetypes.DeployContext) (b
 	}
 
 	if exists {
-		if cheDeployment.Status.AvailableReplicas < 1 {
+		if cheDeployment.Status.AvailableReplicas == 0 {
 			if ctx.CheCluster.Status.ChePhase != chev2.ClusterPhaseInactive {
 				ctx.CheCluster.Status.ChePhase = chev2.ClusterPhaseInactive
 				err := deploy.UpdateCheCRStatus(ctx, "Phase", chev2.ClusterPhaseInactive)
 				return false, err
 			}
-		} else if cheDeployment.Status.Replicas > 1 {
+		} else if cheDeployment.Status.Replicas != cheDeployment.Status.AvailableReplicas {
 			if ctx.CheCluster.Status.ChePhase != chev2.RollingUpdate {
 				ctx.CheCluster.Status.ChePhase = chev2.RollingUpdate
 				err := deploy.UpdateCheCRStatus(ctx, "Phase", chev2.RollingUpdate)