update namespace strategies with new CHE_INFRA_KUBERNETES_NAMESPACE v… #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariable and <workspaceid> placeholder Signed-off-by: Michal Vala <mvala@redhat.com>
|
@rkratky great, thanks. I've merged that to the branch. |
|
Please don NOT merge this! It's documenting changes from PR eclipse-che/che#14828 so we need to merge that one first, then the docs. |
|
@sparkoo, sure, please, let me know you're ready. |
metlos
approved these changes
Oct 21, 2019
rkratky
approved these changes
Oct 21, 2019
|
@rkratky the code PR was merged. We're good to go with this one. |
|
@sparkoo, thanks. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ariable and placeholder
Signed-off-by: Michal Vala mvala@redhat.com
What does this PR do?
Updates workspace namespaces strategies docs. In this PR eclipse-che/che#14828, the
che.infra.kubernetes.namespaceandche.infra.openshift.projectwill became obsolete and are replaced withche.infra.kubernetes.namespace.default. This PR updates the docs.Also There is new
<workspaceid>placeholder. This effectively replaces the default empty value resolving to workspace id.What issues does this PR fix or reference?
eclipse-che/che#14585