Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for the che_workspace_failure_total and che_workspace_status metrics. #658

Merged
merged 3 commits into from
Jan 22, 2019

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Jan 10, 2019

What does this PR do?

Add release notes for the che_workspace_failure_total and che_workspace_status metrics.

What issues does this PR fix or reference?

eclipse-che/che#12242
eclipse-che/che#12368
eclipse-che/che#12092


Eclipse Che 6.17 includes:

* **Workspace failure count metric**: Prometheus metric counting the number of workspace failures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description here should be from the point of view of user benefit, and should be descriptive: "Keep track of workspace failures" is better. The description should be a sentence: "Added a metric to Prometheus to count the number of workspace failures".


## Release details

### Workspace failure count metric
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title should be more descriptive - same as the summary; I suggest "Keep track of workspace failures" is easier to parse.

@dneary
Copy link
Contributor

dneary commented Jan 21, 2019

Have the comments been resolved here? I could merge and fix in-place post-merge, if that works better for the Dev teams, but I would like to ensure that RN changes use a consistent format to reduce rework.

@metlos
Copy link
Contributor Author

metlos commented Jan 22, 2019

Have the comments been resolved here? I could merge and fix in-place post-merge, if that works better for the Dev teams, but I would like to ensure that RN changes use a consistent format to reduce rework.

Sorry for the delay, somehow I didn't notice your comments. I changed the wording according to your suggestions. Thanks!

@metlos metlos changed the title Add release notes for the che_workspace_failure_total metric. Add release notes for the che_workspace_failure_total and che_workspace_status metrics. Jan 22, 2019
@metlos
Copy link
Contributor Author

metlos commented Jan 22, 2019

This PR now also supersedes #656.

Copy link
Contributor

@dneary dneary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dneary dneary merged commit b43389d into eclipse-che:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants