Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

procedures: native user auth docs #2187

Merged
merged 37 commits into from
Dec 22, 2021
Merged

procedures: native user auth docs #2187

merged 37 commits into from
Dec 22, 2021

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Dec 8, 2021 •
edited
Loading

Signed-off-by: Michal Vala mvala@redhat.com

What does this pull request change?

Provide some details related to native authentication

What issues does this pull request fix or reference?

eclipse-che/che#20847

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@sparkoo
native user auth docs
1b93390 
Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo sparkoo requested review from rkratky, themr0c and a team as code owners December 8, 2021 08:30
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Click here to review and test in web IDE: Contribute

@sparkoo sparkoo changed the title native user auth docs procedures: native user auth docs Dec 8, 2021
@themr0c themr0c self-assigned this Dec 9, 2021
@themr0c
Copy link
Contributor

themr0c commented Dec 9, 2021

Some changes added to pass vale checks.

benoitf
benoitf reviewed Dec 21, 2021
View reviewed changes
modules/installation-guide/partials/proc_enabling-dev-workspace-operator.adoc
@@ -32,18 +32,25 @@ spec:
+
[subs="+quotes,+attributes"]
----
$ {prod-cli} server:deploy --che-operator-cr-patch-yaml=patch.yaml ...
$ {prod-cli} server:deploy --workspace-engine=dev-workspace ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's merged into 7.42 this flag won't be needed as devWorkspace will be the default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it break anything? tbh I'm not sure about the release process so I don't know where exactly this will land if I merge today.

@themr0c themr0c merged commit 68e0aef into eclipse-che:master Dec 22, 2021
@sparkoo sparkoo deleted the gh20847-nativeUserAuth branch December 22, 2021 11:06
@che-bot che-bot added this to the 7.41 milestone Dec 22, 2021
@tolusha tolusha mentioned this pull request Jan 25, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themr0c themr0c themr0c approved these changes

@benoitf benoitf benoitf approved these changes

@rkratky rkratky Awaiting requested review from rkratky

@nickboldt nickboldt Awaiting requested review from nickboldt nickboldt was automatically assigned from eclipse/ecd-che-docs-reviewers

@mshaposhnik mshaposhnik Awaiting requested review from mshaposhnik

@xbaran4 xbaran4 Awaiting requested review from xbaran4

@tolusha tolusha Awaiting requested review from tolusha

@metlos metlos Awaiting requested review from metlos

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

Assignees

@themr0c themr0c

Labels
None yet
Projects
None yet
Milestone
7.41
Development

Successfully merging this pull request may close these issues.
6 participants
@sparkoo @themr0c @metlos @benoitf @skabashnyuk @che-bot