Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mergePlugins to attributes in devfile reference and fix minor issues in doc #1576

Merged
merged 3 commits into from
Sep 15, 2020

Conversation

amisevsk
Copy link
Contributor

What does this PR do?

Adds documentation for eclipse-che/che#17785 to explain new devfile attribute. Also fixes minor issues in the doc:

  • Add asyncPersist to devfile reference, as it was previously missing.
  • Fix a vale error on TODO in the doc
  • Fix indentation on a yaml code block.

What issues does this PR fix or reference?

Required for eclipse-che/che#15373

Specify the version of the product this PR applies to.

7.19.x

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successufully against the PR branch
    • Vale lists 12 errors on the devfile reference, but they're all spurious (using "zip" in a code sample is an error, but it's the devfile spec not prose).
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
    • ???
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

Note: I wasn't able to check xref links fully as I ran into issues starting a workspace from the devfile on Hosted Che.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Copy link

@yhontyk yhontyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhontyk yhontyk merged commit 781ab0f into eclipse-che:master Sep 15, 2020
@che-bot che-bot added this to the 7.19 milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants