WIP: Add article about mounting secrets as files and env; - Reviewing by mmaler #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
yhontyk,
l0rd,
MichalMaler,
rkratky and
themr0c
as code owners
MichalMaler
changed the title
skabashnyuk
reviewed
May 28, 2020
...che-7/end-user-guide/proc_mount-secret-as-a-environment-variable-in-workspace-container.adoc
Outdated
Show resolved
Hide resolved
...che-7/end-user-guide/proc_mount-secret-as-a-environment-variable-in-workspace-container.adoc
Outdated
Show resolved
Hide resolved
...che-7/end-user-guide/proc_mount-secret-as-a-environment-variable-in-workspace-container.adoc
Outdated
Show resolved
Hide resolved
...che-7/end-user-guide/proc_mount-secret-as-a-environment-variable-in-workspace-container.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/end-user-guide/proc_mount-secret-as-a-file-in-workspace-container.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/end-user-guide/proc_mount-secret-as-a-file-in-workspace-container.adoc
Outdated
Show resolved
Hide resolved
|
I am rewriting it here. Please, let your comments there. |
MichalMaler
changed the title
Signed-off-by: Michal Maléř <mmaler@redhat.com>
mshaposhnik
commented
Jun 2, 2020
...end-user-guide/assembly_mounting-secrets-as-file-or-env-variable-in-workspace-container.adoc
Outdated
Show resolved
Hide resolved
mshaposhnik
commented
Jun 2, 2020
...end-user-guide/assembly_mounting-secrets-as-file-or-env-variable-in-workspace-container.adoc
Outdated
Show resolved
Hide resolved
|
In general, LGTM! Minor fixes proposed. |
Signed-off-by: Michal Maléř <mmaler@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add article about mounting secrets as files and env;
What issues does this PR fix or reference?
eclipse-che/che#14680
Specify the version of the product this PR applies to.
7.14