-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Git Servies tab to the User Preferences #687
Changes from all commits
6ba48be
4912611
ce832b0
9e21e9c
17347eb
0bbb129
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ import { FastifyInstance } from 'fastify'; | |
export function addAuthorizationHooks(server: FastifyInstance) { | ||
server.addHook('onResponse', (request, reply, done) => { | ||
if ( | ||
(request.url.startsWith('/api/') || request.url.startsWith('/dashboard/api/')) && | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @olexii4 could you please clarify why do we need this change, as I recall There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This code is only for a local run. I added the following changes
->
because I already have a code that can return status code '401' from CHE-Server API:
|
||
request.url.startsWith('/dashboard/api/') && | ||
request.method === 'GET' && | ||
reply.statusCode === 401 | ||
) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a useless variable assignment. Don't you mind getting rid of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this variable out of the loop because we can have several errors until rejecting the last one.