Fix kube config flow

[olexii4]

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Fix kube config flow

What issues does this PR fix or reference?

fixes eclipse-che/che#21454

Is it tested? How?

1. Deploy Eclipse CHE
2. Create a new workspace from one of the samples.
3. config file should be in ~/.kube/

$ ls ~/.kube/

You can test it with https://eclipse-che.apps.cluster-k865s.k865s.sandbox811.opentlc.com

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[che-bot]

Click here to review and test in web IDE:

[codecov]

Codecov Report

Merging #562 (923b659) into main (f6cb102) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   56.14%   56.23%   +0.08%     
==========================================
  Files         216      217       +1     
  Lines        7385     7375      -10     
  Branches     1262     1265       +3     
==========================================
+ Hits         4146     4147       +1     
+ Misses       3060     3049      -11     
  Partials      179      179              

Flag	Coverage Δ
unittests	56.23% <0.00%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ontend/src/store/Workspaces/devWorkspaces/index.ts	9.19% <0.00%> (-0.10%)	⬇️
packages/dashboard-frontend/src/Layout/index.tsx	0.00% <0.00%> (ø)
...ges/dashboard-frontend/src/store/Branding/index.ts	0.00% <0.00%> (ø)
...s/dashboard-frontend/src/services/helpers/login.ts	50.00% <0.00%> (ø)
...rd-frontend/src/services/workspace-client/index.ts	31.03% <0.00%> (+5.32%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6cb102...923b659. Read the comment docs.

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-562

[ibuziuk]

tested locally against dogfooding and there is one thing I can not grok:

bash-4.4$ cat ~/.kube/config 
{"apiVersion":"v1","kind":"Config","clusters":[{"name":"api-che-dev-x6e0-p1-openshiftapps-com:6443","cluster":{"server":"https://api.che-dev.x6e0.p1.openshiftapps.com:6443","insecure-skip-tls-verify":false}}],"users":[{"name":"developer","user":{"token":"<token>"}}],"contexts":[{"name":"logged-user","context":{"user":"developer","cluster":"api-che-dev-x6e0-p1-openshiftapps-com:6443","name":"logged-user"}}],"preferences":{},"current-context":"logged-user"}
bash-4.4$ oc whoami
ibuziuk

Basically, oc whoami reports the right user, but the kube config file refers to the developer user. wondering if this is expected? Basically, the token that is injected in file is the correct one and belongs to my user, but it is a bit strange to see the developer reference.

[ibuziuk]

@akurinnoy thanks for the pointer https://github.com/eclipse-che/che-dashboard/blob/main/packages/dashboard-backend/src/services/kubeclient/kubeConfigProvider.ts#L39-L46

looks like the logic for retrieving the username is failing atm. Can be fixed in a separate PR though

[ibuziuk]

LGTM 👍
the problem with username detection can be fixed in a separate PR I believe. I think we should not fall back on token itself for username since it is a sha256 one-way hash that can not be decrypted.

[che-bot]

Click here to review and test in web IDE:

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-562

[openshift-ci]

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v8-dashboard-happy-path	7e35534	link	true	/test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[l0rd]

Thanks @olexii4 for the rapid fix. I am not sure if it's even necessary to get the right username. It looks like the only important thing is the token anyway.