Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New blog post about Che deployment on AKS #29

Merged
merged 39 commits into from
Jul 25, 2022
Merged

New blog post about Che deployment on AKS #29

merged 39 commits into from
Jul 25, 2022

Conversation

karatkep
Copy link
Contributor

@karatkep karatkep commented Jul 4, 2022

Our story about how we installed Eclipse Che on Microsoft Azure, what problems we met and how solved them.

@karatkep karatkep mentioned this pull request Jul 4, 2022
Closed
@karatkep
Copy link
Contributor Author

karatkep commented Jul 4, 2022

CC @l0rd to help with review

sparkoo
sparkoo approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@sparkoo sparkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karatkep
Copy link
Contributor Author

karatkep commented Jul 7, 2022

Added conclusion
cc @serguei-gorokhov

@karatkep
Copy link
Contributor Author

We added more details to the blog post. So this is a final version of proposed blog post.

@l0rd , @sparkoo , could you please review one more time? Thanks in advance!

ibuziuk
ibuziuk approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, great content 👍
Added the suggestion for the title to make it more straightforward, drop the negative connotation (not work) and the particular versioning detail that is explained in the blog

karatkep and others added 2 commits July 14, 2022 20:15
@karatkep @ibuziuk
Update _posts/2022-07-XX-why-che-could-not-work-under-aks.adoc
72168d2 
title updated

Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>
@karatkep
fixed typos
fa8d254
@ibuziuk
Copy link
Member

ibuziuk commented Jul 15, 2022

@karatkep could you please update the blog file with the publication date (we could probably target Monday 07.25) and make the file name match the blog's title. Will wait for the final approval from @l0rd next week before merging.

@karatkep
Copy link
Contributor Author

@ibuziuk thank you. Updated according to the recommendations.

@l0rd l0rd mentioned this pull request Jul 19, 2022
Closed
@l0rd
Copy link
Contributor

l0rd commented Jul 19, 2022 •
edited
Loading

A quick update: I have started a review draft and plan to finish later today.

@ibuziuk ibuziuk mentioned this pull request Jul 19, 2022
Closed
51 tasks
l0rd
l0rd reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @karatkep, this blog post is great. There is a lot of work behind that. I made a few wording tweaks, please go through them and accept or comment.

_posts/2022-07-25-installing-eclipse-che-on-aks.adoc Outdated Show resolved Hide resolved
_posts/2022-07-25-installing-eclipse-che-on-aks.adoc Outdated Show resolved Hide resolved
_posts/2022-07-25-installing-eclipse-che-on-aks.adoc Outdated Show resolved Hide resolved
_posts/2022-07-25-installing-eclipse-che-on-aks.adoc Outdated Show resolved Hide resolved
_posts/2022-07-25-installing-eclipse-che-on-aks.adoc Outdated Show resolved Hide resolved
_posts/2022-07-25-installing-eclipse-che-on-aks.adoc Outdated Show resolved Hide resolved
_posts/2022-07-25-installing-eclipse-che-on-aks.adoc Outdated Show resolved Hide resolved
_posts/2022-07-25-installing-eclipse-che-on-aks.adoc Outdated Show resolved Hide resolved
_posts/2022-07-25-installing-eclipse-che-on-aks.adoc Outdated Show resolved Hide resolved
_posts/2022-07-25-installing-eclipse-che-on-aks.adoc Outdated Show resolved Hide resolved
karatkep and others added 10 commits July 20, 2022 15:42
@karatkep @l0rd
Update _posts/2022-07-25-installing-eclipse-che-on-aks.adoc
c96a8e9 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@karatkep @l0rd
Update _posts/2022-07-25-installing-eclipse-che-on-aks.adoc
0bfb43f 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@karatkep @l0rd
Update _posts/2022-07-25-installing-eclipse-che-on-aks.adoc
3d55544 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@karatkep @l0rd
Update _posts/2022-07-25-installing-eclipse-che-on-aks.adoc
a2fb688 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@karatkep @l0rd
Update _posts/2022-07-25-installing-eclipse-che-on-aks.adoc
7909648 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@karatkep @l0rd
Update _posts/2022-07-25-installing-eclipse-che-on-aks.adoc
d15e483 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@karatkep @l0rd
Update _posts/2022-07-25-installing-eclipse-che-on-aks.adoc
8245416 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@karatkep @l0rd
Update _posts/2022-07-25-installing-eclipse-che-on-aks.adoc
65a24f5 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@karatkep @l0rd
Update _posts/2022-07-25-installing-eclipse-che-on-aks.adoc
59dc797 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@karatkep @l0rd
Update _posts/2022-07-25-installing-eclipse-che-on-aks.adoc
0c39265 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@karatkep
Copy link
Contributor Author

Thank you @l0rd. Proposed wording tweaks look perfect!

@karatkep @l0rd
Apply suggestions from code review
b7dc024 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
l0rd
l0rd approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l0rd l0rd merged commit a03eb02 into eclipse-che:main Jul 25, 2022
@l0rd
Copy link
Contributor

l0rd commented Jul 26, 2022

Thank you @karatkep, feel free to retweet.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0rd l0rd l0rd approved these changes

@sparkoo sparkoo sparkoo approved these changes

@ibuziuk ibuziuk ibuziuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karatkep @ibuziuk @l0rd @sparkoo