[CI][workflows] Use node 20 by default, align GitHub workflows #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
force-pushed
the
prepare-node-20
branch
7 times, most recently
from
7ffa566 to
b461dc0
Compare
bhufmann
requested changes
Feb 7, 2025
.github/workflows/ci-cd.yml
Outdated
| @@ -119,14 +120,14 @@ jobs: | |||
|
|
|||
| publish-vs-marketplace: | |||
| # https://marketplace.visualstudio.com/ | |||
| name: Publish extension to Visual Studio Marketplace | |||
| name: Publish extension to Visual Studio Marketplace (${{ matrix.os }} | |||
There was a problem hiding this comment.
You might have the issue here too
There was a problem hiding this comment.
Good catch\
.github/workflows/ci-cd.yml
Outdated
| @@ -86,14 +87,14 @@ jobs: | |||
|
|
|||
| publish-oxsv: | |||
| # https://open-vsx.org/ | |||
| name: Publish extension to public Open VSX Registry | |||
| name: Publish extension to public Open VSX Registry (${{ matrix.os }}) | |||
There was a problem hiding this comment.
I see matrix.os printed instead of the actual value. Maybe it can't be resolved when it's skipped. You could hard code it or just omit as it was before.
There was a problem hiding this comment.
The reason I wanted to include it is that when do not, then automatically all matrix variable values are printed-out, without their corresponding "key", which looks strange. But that does not actually happen for these release workflows, that are triggered by an action vs directly by a PR push.
So I'll remove the change for these and we should be good
marcdumais-work
force-pushed
the
prepare-node-20
branch
from
b461dc0 to
71fae99
Compare
Prepare for node.js 18 EoL and transition to node 20 as default - start using node 20 for jobs like linting, publishing and license check - Add Node 20 and node 22 to the matrix for "build and test" job - (for now) Keep node 18 as part of the "matrix" for "build and test job". We can remove it once officially EoL The plan is to remove node 18 soon, when it's officially EoL. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
force-pushed
the
prepare-node-20
branch
from
71fae99 to
fcb9c5b
Compare
marcdumais-work
changed the title
bhufmann
approved these changes
Feb 10, 2025
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Prepare for node.js 18 EoL and our transition to using node 20 as default.
How to test
Confirm CI still passes.
Follow-ups
Review checklist