Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform automated 3PP license check as part of CI for PRs #268

Closed
marcdumais-work opened this issue Jan 19, 2024 · 0 comments · Fixed by #269
Closed

Perform automated 3PP license check as part of CI for PRs #268

marcdumais-work opened this issue Jan 19, 2024 · 0 comments · Fixed by #269
Assignees
@marcdumais-work

Comments

@marcdumais-work
Copy link
Contributor

At a minimum, a 3PP license check needs to be performed before any release of an Eclipse Foundation project component, but ideally it should be done for each PR before merging, to catch 3PPs with incompatible or unclear licenses as early as possible.

We have been working on a standalone nodejs wrapper for Eclipse Foundation's dash-licenses, that can be used to easily add 3PP license checks in JS/TS repositories:

https://github.com/eclipse-dash/nodejs-wrapper

We will soon have its first release to npm, and thereafter it can be easily be added as a devDependency and used in this repo and others in this organization.
@marcdumais-work marcdumais-work self-assigned this Jan 19, 2024
marcdumais-work added a commit that referenced this issue Jan 19, 2024
@marcdumais-work
WIP - Add 3PP license check as part of PR CI
95464f7 
Closes #268

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@marcdumais-work marcdumais-work mentioned this issue Jan 19, 2024
Merged
marcdumais-work added a commit that referenced this issue Jan 29, 2024
@marcdumais-work
WIP - Add 3PP license check as part of PR CI
18b92d6 
Closes #268

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit that referenced this issue Jan 29, 2024
@marcdumais-work
Add 3PP license check as part of PR CI
e2e132e 
The license check can be triggered locally:
  yarn license:check

For automatic opening of IP tickets for suspicious depedencies, set an
Eclipse Foundation gitlab token as environment variable "DASH_TOKEN" and
run the alternate pacakge.json script. e.g.:
  export DASH_TOKEN="<your token>"
  yarn license:check:reviewAdd 3PP license check as part of PR CI

Closes #268

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcdumais-work marcdumais-work

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 3PP license check as part of PR CI eclipse-cdt-cloud/timeline-chart
1 participant
@marcdumais-work