Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeGraphChart mouse and keyhandlers cannot be removed #120

Closed
bhufmann opened this issue Apr 14, 2021 · 0 comments · Fixed by #121
Closed

TimeGraphChart mouse and keyhandlers cannot be removed #120

bhufmann opened this issue Apr 14, 2021 · 0 comments · Fixed by #121

Comments

@bhufmann
Copy link
Collaborator

Handlers that are added to the canvas in TimeGraphChart with onCanvasEvent().

So if the component that added a handler is unmounted, its handler will continue to be called.
bhufmann added a commit to bhufmann/timeline-chart that referenced this issue Apr 14, 2021
@bhufmann
Add APIs to clean-up components and to remove event handlers
90cfe40 
When being destroyed, make sure that all children are removed as well as
all event handlers are removed to avoid

Fixes eclipse-cdt-cloud#98
Fixes eclipse-cdt-cloud#120

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
@bhufmann bhufmann mentioned this issue Apr 14, 2021
Merged
bhufmann added a commit to bhufmann/timeline-chart that referenced this issue Apr 21, 2021
@bhufmann
Add APIs to clean-up components and to remove event handlers
894a2cc 
When being destroyed, make sure that all children are removed as well as
all event handlers are removed to avoid unexpected handler calls.

Fixes eclipse-cdt-cloud#98
Fixes eclipse-cdt-cloud#120

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
bhufmann added a commit to bhufmann/timeline-chart that referenced this issue Apr 30, 2021
@bhufmann
Add APIs to clean-up components and to remove event handlers
4fc6b3e 
When being destroyed, make sure that all children are removed as well as
all event handlers are removed to avoid unexpected handler calls.

Fixes eclipse-cdt-cloud#98
Fixes eclipse-cdt-cloud#120

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
bhufmann added a commit to bhufmann/timeline-chart that referenced this issue May 3, 2021
@bhufmann
Add APIs to clean-up components and to remove event handlers
47bbb2e 
When being destroyed, make sure that all children are removed as well as
all event handlers are removed to avoid unexpected handler calls.

Fixes eclipse-cdt-cloud#98
Fixes eclipse-cdt-cloud#120

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
bhufmann added a commit to bhufmann/timeline-chart that referenced this issue May 3, 2021
@bhufmann
Add APIs to clean-up components and to remove event handlers
1dad0af 
When being destroyed, make sure that all children are removed as well as
all event handlers are removed to avoid unexpected handler calls.

Fixes eclipse-cdt-cloud#98
Fixes eclipse-cdt-cloud#120

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
bhufmann added a commit to bhufmann/timeline-chart that referenced this issue May 3, 2021
@bhufmann
Add APIs to clean-up components and to remove event handlers
b01fd59 
When being destroyed, make sure that all children are removed as well as
all event handlers are removed to avoid unexpected handler calls.

Fixes eclipse-cdt-cloud#98
Fixes eclipse-cdt-cloud#120

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
bhufmann added a commit that referenced this issue May 3, 2021
@bhufmann
Add APIs to clean-up components and to remove event handlers
4b97ae9 
When being destroyed, make sure that all children are removed as well as
all event handlers are removed to avoid unexpected handler calls.

Fixes #98
Fixes #120

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add APIs to clean-up components and to remove event handlers bhufmann/timeline-chart
1 participant
@bhufmann