Skip to content

Commit

Permalink
World range updates with fine resolution
Browse files Browse the repository at this point in the history
World range now updates for fine resolution calls to maybeFetchNewData.
The fine resolution check was meant to be an optimization,
but did not actually optimize anything and created bugs.
This check is removed.

Signed-off-by: Will Yang <william.yang@ericsson.com>
  • Loading branch information
williamsyang-work authored and bhufmann committed Jan 6, 2023
1 parent 4c1edfd commit f029da1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion timeline-chart/src/layer/time-graph-chart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ export class TimeGraphChart extends TimeGraphChartLayer {
// Only on coarse renders
// Only if we are updating all rows and not increasing vertical height. See: https://github.com/eclipse-cdt-cloud/theia-trace-extension/pull/832#issuecomment-1259902534.
const allRowsUpdated = rowIds.length === visibleRowIds.length;
const worldRange = (!fine && allRowsUpdated) ? this.unitController.updateWorldRangeFromViewRange() : this.unitController.worldRange;
const worldRange = allRowsUpdated ? this.unitController.updateWorldRangeFromViewRange() : this.unitController.worldRange;
const request = { worldRange, resolution, rowIds };
if (isEqual(request, this.ongoingRequest)) {
// request ignored because equal to ongoing request
Expand Down

0 comments on commit f029da1

Please sign in to comment.