Destroy arrows when updating them

Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
eclipse-cdt-cloud · Apr 20, 2021 · 40986f2 · 40986f2
1 parent 8f77d88
commit 40986f2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/timeline-chart/src/components/time-graph-arrow.ts b/timeline-chart/src/components/time-graph-arrow.ts
@@ -17,6 +17,11 @@ export class TimeGraphArrowComponent extends TimeGraphComponent {
         this.head = new PIXI.Graphics();
     }
 
+    destroy() {
+        this.head.destroy();
+        super.destroy();
+    }
+
     render(): void {
         const { start, end } = this._options as TimeGraphArrowCoordinates;
         this._displayObject.lineStyle(1, 0x000000);

diff --git a/timeline-chart/src/components/time-graph-component.ts b/timeline-chart/src/components/time-graph-component.ts
@@ -59,6 +59,10 @@ export abstract class TimeGraphComponent {
         this._displayObject.clear();
     }
 
+    destroy() {
+        this._displayObject.destroy();
+    }
+
     update(opts?: TimeGraphComponentOptions) {
         if (opts) {
             this._options = opts;

diff --git a/timeline-chart/src/layer/time-graph-chart-arrows.ts b/timeline-chart/src/layer/time-graph-chart-arrows.ts
@@ -39,6 +39,9 @@ export class TimeGraphChartArrows extends TimeGraphChartLayer {
         if (!this.stateController) {
             throw ('Add this TimeGraphChartArrows to a container before adding arrows.');
         }
+        if (this.arrows) {
+            this.arrows.forEach(rowEl => rowEl.destroy());
+        }
         this.arrows = new Map();
         arrows.forEach(arrow => {
             this.addArrow(arrow);